Clone parent data hash when making nested data editable #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When fetching an editable hash via readEditableDataHash for a nested record, make sure we clone the parent record and then return a reference to the parent's child data. This is similar to the behavior already present in the _lock method in NestedStore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When fetching an editable hash via
readEditableDataHashfor a nested record, the nested hash is cloned causing it to get out of sync with its parent. The parent data hash should be cloned instead and a reference to the child hash returned.This behavior is already present in the
_lockmethod ofSC.NestedStore. This pull request ports the code to thereadEditableDataHashmethod ofSC.Storeso that editable hashes are created properly.I noticed this when executing this sequence:
_lockmethod.commitChangeson the NestedStore. This locks the records in the parent store.readEditableDataHashin SC.Store instead of_lock. This clones the data incorrectly.