bugfix: don't publish transaction if it wasn't committed to the database

the-avid-engineer · the-avid-engineer · commit 8c7ba5e04b4e · 2022-11-24T14:52:55.000-08:00
diff --git a/src/EntityDb.Common/Entities/EntityRepository.cs b/src/EntityDb.Common/Entities/EntityRepository.cs
@@ -57,14 +57,14 @@ public async Task<TEntity> GetSnapshot(Pointer entityPointer, CancellationToken
 
     public async Task<bool> PutTransaction(ITransaction transaction, CancellationToken cancellationToken = default)
     {
-        try
-        {
-            return await TransactionRepository.PutTransaction(transaction, cancellationToken);
-        }
-        finally
+        var success = await TransactionRepository.PutTransaction(transaction, cancellationToken);
+
+        if (success)
         {
             Publish(transaction);
         }
+
+        return success;
     }
 
     public override async ValueTask DisposeAsync()

Original file line number	Diff line number	Diff line change
`@@ -57,14 +57,14 @@ public async Task<TEntity> GetSnapshot(Pointer entityPointer, CancellationToken`
`57`	`57`
`58`	`58`	`public async Task<bool> PutTransaction(ITransaction transaction, CancellationToken cancellationToken = default)`
`59`	`59`	`{`
`60`		`- try`
`61`		`- {`
`62`		`- return await TransactionRepository.PutTransaction(transaction, cancellationToken);`
`63`		`- }`
`64`		`- finally`
	`60`	`+ var success = await TransactionRepository.PutTransaction(transaction, cancellationToken);`
	`61`	`+`
	`62`	`+ if (success)`
`65`	`63`	`{`
`66`	`64`	`Publish(transaction);`
`67`	`65`	`}`
	`66`	`+`
	`67`	`+ return success;`
`68`	`68`	`}`
`69`	`69`
`70`	`70`	`public override async ValueTask DisposeAsync()`