From c64b8b915846565003e4bdb64482cabd30330bd1 Mon Sep 17 00:00:00 2001 From: Josh Goldberg Date: Tue, 15 Jul 2025 13:22:02 -0400 Subject: [PATCH 01/11] chore: add lint:unused script to run Knip --- .github/workflows/ci.yml | 3 +++ .github/workflows/release-please.yml | 10 ++++----- knip.json | 30 +++++++++++++++++++++++++++ package.json | 3 ++- packages/compat/package.json | 3 ++- packages/compat/tsconfig.json | 3 ++- packages/config-array/package.json | 3 ++- packages/config-array/tsconfig.json | 3 ++- packages/core/package.json | 2 +- packages/migrate-config/package.json | 1 + packages/migrate-config/tsconfig.json | 3 ++- packages/object-schema/package.json | 3 ++- packages/object-schema/tsconfig.json | 3 ++- packages/plugin-kit/package.json | 3 ++- packages/plugin-kit/tsconfig.json | 3 ++- 15 files changed, 60 insertions(+), 16 deletions(-) create mode 100644 knip.json diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index b8cf1b032..d1dfc7cff 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -27,6 +27,9 @@ jobs: - name: Lint Files run: npm run lint + - name: Lint Files, Dependencies, & Exports + run: npm run lint:unused + - name: Check Formatting run: npm run fmt:check diff --git a/.github/workflows/release-please.yml b/.github/workflows/release-please.yml index d5733d93a..3a200c559 100644 --- a/.github/workflows/release-please.yml +++ b/.github/workflows/release-please.yml @@ -62,7 +62,7 @@ jobs: - name: Publish @eslint/compat package to JSR run: | npm run build --if-present - npx jsr publish + npx -y jsr publish working-directory: packages/compat if: ${{ steps.release.outputs['packages/compat--release_created'] }} @@ -95,7 +95,7 @@ jobs: - name: Publish @eslint/core package to JSR run: | npm run build --if-present - npx jsr publish + npx -y jsr publish working-directory: packages/core if: ${{ steps.release.outputs['packages/core--release_created'] }} @@ -154,7 +154,7 @@ jobs: NODE_AUTH_TOKEN: ${{secrets.NPM_TOKEN}} - name: Publish @eslint/object-schema package to JSR - run: npx jsr publish + run: npx -y jsr publish working-directory: packages/object-schema if: ${{ steps.release.outputs['packages/object-schema--release_created'] }} @@ -185,7 +185,7 @@ jobs: NODE_AUTH_TOKEN: ${{secrets.NPM_TOKEN}} - name: Publish @eslint/config-array package to JSR - run: npx jsr publish + run: npx -y jsr publish working-directory: packages/config-array if: ${{ steps.release.outputs['packages/config-array--release_created'] }} @@ -216,7 +216,7 @@ jobs: NODE_AUTH_TOKEN: ${{secrets.NPM_TOKEN}} - name: Publish @eslint/plugin-kit package to JSR - run: npx jsr publish + run: npx -y jsr publish working-directory: packages/plugin-kit if: ${{ steps.release.outputs['packages/plugin-kit--release_created'] }} diff --git a/knip.json b/knip.json new file mode 100644 index 000000000..23681f9a1 --- /dev/null +++ b/knip.json @@ -0,0 +1,30 @@ +{ + "workspaces": { + ".": { + "entry": ["scripts/*.js", "tools/*.js", ".github/workflows/*.yml"] + }, + "packages/migrate-config": { + "entry": ["src/migrate-config.js", "tests/**/*.{js,ts}"], + "project": ["src/**/*.{js,ts}", "tests/*.{js,ts}"] + }, + "packages/config-array": { + "entry": ["tests/**/*.{js,ts}", "rollup.std__path-config.js"], + "project": ["src/**/*.{js,ts}", "tests/**/*.{js,ts}"] + }, + "packages/plugin-kit": { + "entry": ["tests/**/*.{js,ts}"], + "project": ["src/**/*.{js,ts}", "tests/**/*.{js,ts}"] + }, + "packages/compat": { + "entry": ["tests/**/*.{js,ts}"], + "project": ["src/**/*.{js,ts}", "tests/*.{js,ts}"] + }, + "packages/object-schema": { + "entry": ["tests/**/*.{js,ts}", "src/types.ts"], + "project": ["src/**/*.{js,ts}", "tests/**/*.{js,ts}"] + }, + "packages/core": { + "project": ["src/**/*.{js,ts}"] + } + } +} diff --git a/package.json b/package.json index 3b17f7e89..fd19d04d6 100644 --- a/package.json +++ b/package.json @@ -9,6 +9,7 @@ "build:readme": "node tools/update-readme.js", "lint": "eslint .", "lint:fix": "eslint --fix .", + "lint:unused": "knip", "fmt": "prettier --write .", "fmt:check": "prettier --check .", "test:jsr": "npm run test:jsr --workspaces --if-present", @@ -28,10 +29,10 @@ "!(*.{js,ts})": "prettier --write --ignore-unknown" }, "devDependencies": { - "@types/mocha": "^10.0.7", "eslint": "^9.11.1", "eslint-config-eslint": "^11.0.0", "got": "^14.4.1", + "knip": "^5.61.3", "lint-staged": "^15.2.0", "prettier": "^3.1.1", "typescript": "^5.5.3", diff --git a/packages/compat/package.json b/packages/compat/package.json index 31117e346..0a09b8575 100644 --- a/packages/compat/package.json +++ b/packages/compat/package.json @@ -27,7 +27,7 @@ "scripts": { "build:cts": "node -e \"fs.copyFileSync('dist/esm/index.d.ts', 'dist/cjs/index.d.cts')\"", "build": "rollup -c && tsc -p tsconfig.esm.json && npm run build:cts", - "test:jsr": "npx jsr@latest publish --dry-run", + "test:jsr": "npx -y jsr@latest publish --dry-run", "test": "mocha tests/*.js", "test:coverage": "c8 npm test" }, @@ -49,6 +49,7 @@ "homepage": "https://github.com/eslint/rewrite#readme", "devDependencies": { "@eslint/core": "^0.9.0", + "@types/mocha": "^10.0.7", "c8": "^9.1.0", "eslint": "^9.11.0", "mocha": "^10.4.0", diff --git a/packages/compat/tsconfig.json b/packages/compat/tsconfig.json index 5d8149a44..cb82c2812 100644 --- a/packages/compat/tsconfig.json +++ b/packages/compat/tsconfig.json @@ -2,6 +2,7 @@ "extends": "../../tsconfig.base.json", "files": ["src/index.js"], "compilerOptions": { - "outDir": "dist/esm" + "outDir": "dist/esm", + "types": ["mocha", "@eslint/core"] } } diff --git a/packages/config-array/package.json b/packages/config-array/package.json index 299906b66..84a5faec6 100644 --- a/packages/config-array/package.json +++ b/packages/config-array/package.json @@ -35,7 +35,7 @@ "build:cts": "node -e \"fs.copyFileSync('dist/esm/index.d.ts', 'dist/cjs/index.d.cts')\"", "build:std__path": "rollup -c rollup.std__path-config.js && node fix-std__path-imports", "build": "rollup -c && npm run build:dedupe-types && tsc -p tsconfig.esm.json && npm run build:cts && npm run build:std__path", - "test:jsr": "npx jsr@latest publish --dry-run", + "test:jsr": "npx -y jsr@latest publish --dry-run", "pretest": "npm run build", "test": "mocha tests/", "test:coverage": "c8 npm test" @@ -54,6 +54,7 @@ "devDependencies": { "@jsr/std__path": "^1.0.4", "@types/minimatch": "^3.0.5", + "@types/mocha": "^10.0.7", "c8": "^9.1.0", "mocha": "^10.4.0", "rollup": "^4.16.2", diff --git a/packages/config-array/tsconfig.json b/packages/config-array/tsconfig.json index 5d8149a44..ba0bc9bf6 100644 --- a/packages/config-array/tsconfig.json +++ b/packages/config-array/tsconfig.json @@ -2,6 +2,7 @@ "extends": "../../tsconfig.base.json", "files": ["src/index.js"], "compilerOptions": { - "outDir": "dist/esm" + "outDir": "dist/esm", + "types": ["mocha"] } } diff --git a/packages/core/package.json b/packages/core/package.json index 797e3a656..70fc2b9a5 100644 --- a/packages/core/package.json +++ b/packages/core/package.json @@ -19,7 +19,7 @@ "scripts": { "build:cts": "node -e \"fs.cpSync('dist/esm/types.d.ts', 'dist/cjs/types.d.cts')\"", "build": "tsc && npm run build:cts", - "test:jsr": "npx jsr@latest publish --dry-run" + "test:jsr": "npx -y jsr@latest publish --dry-run" }, "repository": { "type": "git", diff --git a/packages/migrate-config/package.json b/packages/migrate-config/package.json index 0e47fd03d..2092e3efd 100644 --- a/packages/migrate-config/package.json +++ b/packages/migrate-config/package.json @@ -38,6 +38,7 @@ "homepage": "https://github.com/eslint/rewrite#readme", "devDependencies": { "@types/eslint": "^9.6.0", + "@types/mocha": "^10.0.7", "eslint": "^9.0.0", "mocha": "^10.4.0", "typescript": "^5.4.5" diff --git a/packages/migrate-config/tsconfig.json b/packages/migrate-config/tsconfig.json index 4e6f7b34c..d121e58c4 100644 --- a/packages/migrate-config/tsconfig.json +++ b/packages/migrate-config/tsconfig.json @@ -2,6 +2,7 @@ "extends": "../../tsconfig.base.json", "files": ["src/migrate-config-cli.js"], "compilerOptions": { - "outDir": "dist/esm" + "outDir": "dist/esm", + "types": ["mocha", "@types/eslint"] } } diff --git a/packages/object-schema/package.json b/packages/object-schema/package.json index 2a09a765f..397655f04 100644 --- a/packages/object-schema/package.json +++ b/packages/object-schema/package.json @@ -27,7 +27,7 @@ "scripts": { "build:cts": "node -e \"fs.copyFileSync('dist/esm/index.d.ts', 'dist/cjs/index.d.cts')\"", "build": "rollup -c && tsc -p tsconfig.esm.json && npm run build:cts", - "test:jsr": "npx jsr@latest publish --dry-run", + "test:jsr": "npx -y jsr@latest publish --dry-run", "test": "mocha tests/", "test:coverage": "c8 npm test" }, @@ -48,6 +48,7 @@ }, "homepage": "https://github.com/eslint/rewrite#readme", "devDependencies": { + "@types/mocha": "^10.0.7", "c8": "^9.1.0", "mocha": "^10.4.0", "rollup": "^4.16.2", diff --git a/packages/object-schema/tsconfig.json b/packages/object-schema/tsconfig.json index 5d8149a44..ba0bc9bf6 100644 --- a/packages/object-schema/tsconfig.json +++ b/packages/object-schema/tsconfig.json @@ -2,6 +2,7 @@ "extends": "../../tsconfig.base.json", "files": ["src/index.js"], "compilerOptions": { - "outDir": "dist/esm" + "outDir": "dist/esm", + "types": ["mocha"] } } diff --git a/packages/plugin-kit/package.json b/packages/plugin-kit/package.json index bb29a554d..8a36144e6 100644 --- a/packages/plugin-kit/package.json +++ b/packages/plugin-kit/package.json @@ -34,7 +34,7 @@ "build:dedupe-types": "node ../../tools/dedupe-types.js dist/cjs/index.cjs dist/esm/index.js", "build:cts": "node -e \"fs.copyFileSync('dist/esm/index.d.ts', 'dist/cjs/index.d.cts')\"", "build": "rollup -c && npm run build:dedupe-types && tsc -p tsconfig.esm.json && npm run build:cts", - "test:jsr": "npx jsr@latest publish --dry-run", + "test:jsr": "npx -y jsr@latest publish --dry-run", "pretest": "npm run build", "test": "mocha tests/", "test:coverage": "c8 npm test" @@ -48,6 +48,7 @@ "devDependencies": { "@eslint/core": "^0.9.0", "@types/levn": "^0.4.0", + "@types/mocha": "^10.0.7", "c8": "^9.1.0", "mocha": "^10.4.0", "rollup": "^4.16.2", diff --git a/packages/plugin-kit/tsconfig.json b/packages/plugin-kit/tsconfig.json index 779639cfe..50bbb3cf2 100644 --- a/packages/plugin-kit/tsconfig.json +++ b/packages/plugin-kit/tsconfig.json @@ -3,6 +3,7 @@ "files": ["src/index.js"], "compilerOptions": { "outDir": "dist/esm", - "strict": true + "strict": true, + "types": ["mocha"] } } From 04af85b450914bcdfbf5d0d07d12342f2b5fbf87 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Josh=20Goldberg=20=E2=9C=A8?= Date: Fri, 15 Aug 2025 07:57:03 -0600 Subject: [PATCH 02/11] Update packages/compat/tsconfig.json MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: 루밀LuMir --- packages/compat/tsconfig.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/compat/tsconfig.json b/packages/compat/tsconfig.json index cb82c2812..40920a1e9 100644 --- a/packages/compat/tsconfig.json +++ b/packages/compat/tsconfig.json @@ -3,6 +3,6 @@ "files": ["src/index.js"], "compilerOptions": { "outDir": "dist/esm", - "types": ["mocha", "@eslint/core"] + "types": ["mocha", "@eslint/core", "node"] } } From d140619077150c129621ab4f96078d2439762ac8 Mon Sep 17 00:00:00 2001 From: Josh Goldberg Date: Fri, 15 Aug 2025 08:00:54 -0600 Subject: [PATCH 03/11] add back Knip and lint:unused script --- package.json | 2 ++ 1 file changed, 2 insertions(+) diff --git a/package.json b/package.json index 78cafa698..e52c39703 100644 --- a/package.json +++ b/package.json @@ -11,6 +11,7 @@ "prepare": "npm run build", "lint": "eslint .", "lint:fix": "eslint --fix .", + "lint:unused": "knip", "fmt": "prettier --write .", "fmt:check": "prettier --check .", "test:jsr": "npm run test:jsr --workspaces --if-present", @@ -39,6 +40,7 @@ "eslint": "^9.27.0", "eslint-config-eslint": "^11.0.0", "got": "^14.4.1", + "knip": "^5.62.0", "lint-staged": "^15.2.0", "mocha": "^11.5.0", "prettier": "^3.4.1", From cb017d9db2f539e4ba4d1e20f87edf11beeef20a Mon Sep 17 00:00:00 2001 From: Josh Goldberg Date: Fri, 15 Aug 2025 08:04:10 -0600 Subject: [PATCH 04/11] Reduced complaints back down to 0 --- knip.json | 25 ++++++++++++++++--------- packages/config-helpers/package.json | 1 - 2 files changed, 16 insertions(+), 10 deletions(-) diff --git a/knip.json b/knip.json index 23681f9a1..242e23695 100644 --- a/knip.json +++ b/knip.json @@ -1,30 +1,37 @@ { + "$schema": "https://unpkg.com/knip@5/schema.json", + "ignore": ["templates/**/*"], "workspaces": { - ".": { - "entry": ["scripts/*.js", "tools/*.js", ".github/workflows/*.yml"] - }, - "packages/migrate-config": { - "entry": ["src/migrate-config.js", "tests/**/*.{js,ts}"], + ".": { "entry": ["scripts/*.js", "tools/*.js", ".github/workflows/*.yml"] }, + "packages/compat": { + "ignoreDependencies": ["eslint"], + "entry": ["tests/**/*.{js,ts}"], "project": ["src/**/*.{js,ts}", "tests/*.{js,ts}"] }, "packages/config-array": { "entry": ["tests/**/*.{js,ts}", "rollup.std__path-config.js"], "project": ["src/**/*.{js,ts}", "tests/**/*.{js,ts}"] }, - "packages/plugin-kit": { + "packages/config-helpers": { "entry": ["tests/**/*.{js,ts}"], "project": ["src/**/*.{js,ts}", "tests/**/*.{js,ts}"] }, - "packages/compat": { + "packages/core": { "project": ["src/**/*.{js,ts}"] }, + "packages/mcp": { "entry": ["tests/**/*.{js,ts}"], + "project": ["src/**/*.{js,ts}", "tests/**/*.{js,ts}"] + }, + "packages/migrate-config": { + "entry": ["src/migrate-config.js", "tests/**/*.{js,ts}"], "project": ["src/**/*.{js,ts}", "tests/*.{js,ts}"] }, "packages/object-schema": { "entry": ["tests/**/*.{js,ts}", "src/types.ts"], "project": ["src/**/*.{js,ts}", "tests/**/*.{js,ts}"] }, - "packages/core": { - "project": ["src/**/*.{js,ts}"] + "packages/plugin-kit": { + "entry": ["tests/**/*.{js,ts}"], + "project": ["src/**/*.{js,ts}", "tests/**/*.{js,ts}"] } } } diff --git a/packages/config-helpers/package.json b/packages/config-helpers/package.json index 7cba86d29..81c0ee67d 100644 --- a/packages/config-helpers/package.json +++ b/packages/config-helpers/package.json @@ -47,7 +47,6 @@ }, "homepage": "https://github.com/eslint/rewrite/tree/main/packages/config-helpers#readme", "devDependencies": { - "@eslint/core": "^0.15.2", "eslint": "^9.27.0", "rollup-plugin-copy": "^3.5.0" }, From 57f810103fcccec63bd360f5dfd64330c377b7e7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Josh=20Goldberg=20=E2=9C=A8?= Date: Thu, 25 Sep 2025 11:44:46 -0400 Subject: [PATCH 05/11] Apply suggestion from @lumirlumir MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: 루밀LuMir --- packages/migrate-config/tsconfig.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/migrate-config/tsconfig.json b/packages/migrate-config/tsconfig.json index d121e58c4..379a70edb 100644 --- a/packages/migrate-config/tsconfig.json +++ b/packages/migrate-config/tsconfig.json @@ -3,6 +3,6 @@ "files": ["src/migrate-config-cli.js"], "compilerOptions": { "outDir": "dist/esm", - "types": ["mocha", "@types/eslint"] + "types": ["mocha"] } } From bda0a5d44c9acca0131917c4c7aa020d6407c76d Mon Sep 17 00:00:00 2001 From: Josh Goldberg Date: Thu, 25 Sep 2025 11:46:03 -0400 Subject: [PATCH 06/11] Removed eslint/core from compat tsconfig --- packages/compat/tsconfig.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/compat/tsconfig.json b/packages/compat/tsconfig.json index 40920a1e9..4ba326f86 100644 --- a/packages/compat/tsconfig.json +++ b/packages/compat/tsconfig.json @@ -3,6 +3,6 @@ "files": ["src/index.js"], "compilerOptions": { "outDir": "dist/esm", - "types": ["mocha", "@eslint/core", "node"] + "types": ["mocha", "node"] } } From 8cb1ee993edbf4762f8baf38cf7e6ec9c0e95ca5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Josh=20Goldberg=20=E2=9C=A8?= Date: Thu, 25 Sep 2025 11:47:44 -0400 Subject: [PATCH 07/11] Apply suggestion from @lumirlumir MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: 루밀LuMir --- knip.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/knip.json b/knip.json index 242e23695..15692c43a 100644 --- a/knip.json +++ b/knip.json @@ -13,8 +13,8 @@ "project": ["src/**/*.{js,ts}", "tests/**/*.{js,ts}"] }, "packages/config-helpers": { - "entry": ["tests/**/*.{js,ts}"], - "project": ["src/**/*.{js,ts}", "tests/**/*.{js,ts}"] + "entry": ["tests/**/*.{js,ts,cts}"], + "project": ["src/**/*.{js,ts}", "tests/**/*.{js,ts,cts}"] }, "packages/core": { "project": ["src/**/*.{js,ts}"] }, "packages/mcp": { From d10bd58bf91ba80c540a64b79b6e1d4dca5b4d46 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Josh=20Goldberg=20=E2=9C=A8?= Date: Thu, 25 Sep 2025 11:47:57 -0400 Subject: [PATCH 08/11] Apply suggestion from @lumirlumir MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: 루밀LuMir --- knip.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/knip.json b/knip.json index 15692c43a..eddcc80eb 100644 --- a/knip.json +++ b/knip.json @@ -30,8 +30,8 @@ "project": ["src/**/*.{js,ts}", "tests/**/*.{js,ts}"] }, "packages/plugin-kit": { - "entry": ["tests/**/*.{js,ts}"], - "project": ["src/**/*.{js,ts}", "tests/**/*.{js,ts}"] + "entry": ["tests/**/*.{js,ts,cts}"], + "project": ["src/**/*.{js,ts}", "tests/**/*.{js,ts,cts}"] } } } From d4bfef329568f4aa10e09fc0fd62f1784bb7ac48 Mon Sep 17 00:00:00 2001 From: Josh Goldberg Date: Thu, 25 Sep 2025 11:48:44 -0400 Subject: [PATCH 09/11] Standardize on cts,js,ts --- knip.json | 30 +++++++++++++++--------------- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/knip.json b/knip.json index eddcc80eb..5062dcdd4 100644 --- a/knip.json +++ b/knip.json @@ -5,33 +5,33 @@ ".": { "entry": ["scripts/*.js", "tools/*.js", ".github/workflows/*.yml"] }, "packages/compat": { "ignoreDependencies": ["eslint"], - "entry": ["tests/**/*.{js,ts}"], - "project": ["src/**/*.{js,ts}", "tests/*.{js,ts}"] + "entry": ["tests/**/*.{cts,js,ts}"], + "project": ["src/**/*.{cts,js,ts}", "tests/*.{cts,js,ts}"] }, "packages/config-array": { - "entry": ["tests/**/*.{js,ts}", "rollup.std__path-config.js"], - "project": ["src/**/*.{js,ts}", "tests/**/*.{js,ts}"] + "entry": ["tests/**/*.{cts,js,ts}", "rollup.std__path-config.js"], + "project": ["src/**/*.{cts,js,ts}", "tests/**/*.{cts,js,ts}"] }, "packages/config-helpers": { - "entry": ["tests/**/*.{js,ts,cts}"], - "project": ["src/**/*.{js,ts}", "tests/**/*.{js,ts,cts}"] + "entry": ["tests/**/*.{cts,cts,js,ts}"], + "project": ["src/**/*.{cts,js,ts}", "tests/**/*.{cts,cts,js,ts}"] }, - "packages/core": { "project": ["src/**/*.{js,ts}"] }, + "packages/core": { "project": ["src/**/*.{cts,js,ts}"] }, "packages/mcp": { - "entry": ["tests/**/*.{js,ts}"], - "project": ["src/**/*.{js,ts}", "tests/**/*.{js,ts}"] + "entry": ["tests/**/*.{cts,js,ts}"], + "project": ["src/**/*.{cts,js,ts}", "tests/**/*.{cts,js,ts}"] }, "packages/migrate-config": { - "entry": ["src/migrate-config.js", "tests/**/*.{js,ts}"], - "project": ["src/**/*.{js,ts}", "tests/*.{js,ts}"] + "entry": ["src/migrate-config.js", "tests/**/*.{cts,js,ts}"], + "project": ["src/**/*.{cts,js,ts}", "tests/*.{cts,js,ts}"] }, "packages/object-schema": { - "entry": ["tests/**/*.{js,ts}", "src/types.ts"], - "project": ["src/**/*.{js,ts}", "tests/**/*.{js,ts}"] + "entry": ["tests/**/*.{cts,js,ts}", "src/types.ts"], + "project": ["src/**/*.{cts,js,ts}", "tests/**/*.{cts,js,ts}"] }, "packages/plugin-kit": { - "entry": ["tests/**/*.{js,ts,cts}"], - "project": ["src/**/*.{js,ts}", "tests/**/*.{js,ts,cts}"] + "entry": ["tests/**/*.{cts,cts,js,ts}"], + "project": ["src/**/*.{cts,js,ts}", "tests/**/*.{cts,cts,js,ts}"] } } } From 042aead6cc8086cc7600fefe217ce01ed899bb77 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Josh=20Goldberg=20=E2=9C=A8?= Date: Thu, 23 Oct 2025 12:12:14 -0500 Subject: [PATCH 10/11] Apply suggestions from code review Co-authored-by: Percy Ma --- knip.json | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/knip.json b/knip.json index 5062dcdd4..cad406275 100644 --- a/knip.json +++ b/knip.json @@ -13,8 +13,8 @@ "project": ["src/**/*.{cts,js,ts}", "tests/**/*.{cts,js,ts}"] }, "packages/config-helpers": { - "entry": ["tests/**/*.{cts,cts,js,ts}"], - "project": ["src/**/*.{cts,js,ts}", "tests/**/*.{cts,cts,js,ts}"] + "entry": ["tests/**/*.{cts,js,ts}"], + "project": ["src/**/*.{cts,js,ts}", "tests/**/*.{cts,js,ts}"] }, "packages/core": { "project": ["src/**/*.{cts,js,ts}"] }, "packages/mcp": { @@ -30,8 +30,8 @@ "project": ["src/**/*.{cts,js,ts}", "tests/**/*.{cts,js,ts}"] }, "packages/plugin-kit": { - "entry": ["tests/**/*.{cts,cts,js,ts}"], - "project": ["src/**/*.{cts,js,ts}", "tests/**/*.{cts,cts,js,ts}"] + "entry": ["tests/**/*.{cts,js,ts}"], + "project": ["src/**/*.{cts,js,ts}", "tests/**/*.{cts,js,ts}"] } } } From bec181a74bb7af2d71a6e0b3bb96af8a6be1a834 Mon Sep 17 00:00:00 2001 From: Josh Goldberg Date: Thu, 23 Oct 2025 12:21:24 -0500 Subject: [PATCH 11/11] Add @types/node, and remove an eslint devDependency --- package.json | 1 + packages/config-helpers/package.json | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index ce2c7bf52..a70ab5fd3 100644 --- a/package.json +++ b/package.json @@ -35,6 +35,7 @@ "devDependencies": { "@eslint/config-helpers": "file:packages/config-helpers", "@types/mocha": "^10.0.7", + "@types/node": "^24.9.1", "c8": "^10.1.3", "eslint": "^9.35.0", "eslint-config-eslint": "^13.0.0", diff --git a/packages/config-helpers/package.json b/packages/config-helpers/package.json index a4a61048c..5ea0f37ab 100644 --- a/packages/config-helpers/package.json +++ b/packages/config-helpers/package.json @@ -51,7 +51,6 @@ "@eslint/core": "^0.16.0" }, "devDependencies": { - "eslint": "^9.27.0", "rollup-plugin-copy": "^3.5.0" }, "engines": {