Fixed all requests spec and added it to the github workflow (#167)

* added db cleaner

* removed unnecessary files

* fixed roles creation

* fixed roles_spec

* fixed other controller specs

* Fixing participants_controller_spec

* Fixing questions spec and authentication spec

* fixed questions_spec

---------

Co-authored-by: bhavya1803 <[email protected]>

Author: Kashika08

.github/workflows/main.yml

@@ -60,9 +60,12 @@ jobs:
           chmod +x ./cc-test-reporter
           ./cc-test-reporter before-build
 
-      - name: Run tests
+      - name: Run model tests
         run: bundle exec rspec spec/models
 
+      - name: Run controller tests
+        run: bundle exec rspec spec/requests/
+
       - name: Format code coverage report
         run: ./cc-test-reporter format-coverage -t simplecov -o "coverage/codeclimate.models.json" --debug
 

Gemfile

@@ -39,6 +39,7 @@ gem 'find_with_order'
 group :development, :test do
   gem 'debug', platforms: %i[mri mingw x64_mingw]
   gem 'factory_bot_rails'
+  gem 'database_cleaner-active_record'
   gem 'faker'
   gem 'rspec-rails'
   gem 'rswag-specs'

Gemfile.lock

@@ -91,10 +91,14 @@ GEM
       term-ansicolor
       thor
     crass (1.0.6)
+    database_cleaner-active_record (2.2.0)
+      activerecord (>= 5.a)
+      database_cleaner-core (~> 2.0.0)
+    database_cleaner-core (2.0.1)
     date (3.4.1)
-    debug (1.8.0)
-      irb (>= 1.5.0)
-      reline (>= 0.3.1)
+    debug (1.10.0)
+      irb (~> 1.10)
+      reline (>= 0.3.8)
     diff-lcs (1.5.0)
     docile (1.4.0)
     domain_name (0.6.20240107)
@@ -116,7 +120,7 @@ GEM
       domain_name (~> 0.5)
     i18n (1.14.1)
       concurrent-ruby (~> 1.0)
-    io-console (0.6.0)
+    io-console (0.8.0)
     irb (1.15.1)
       pp (>= 0.6.0)
       rdoc (>= 4.0.0)
@@ -281,7 +285,7 @@ GEM
     simplecov-html (0.12.3)
     simplecov_json_formatter (0.1.4)
     spring (4.1.1)
-    stringio (3.1.4)
+    stringio (3.1.5)
     sync (0.5.0)
     term-ansicolor (1.11.2)
       tins (~> 1.0)
@@ -315,6 +319,7 @@ DEPENDENCIES
   bcrypt (~> 3.1.7)
   bootsnap (>= 1.18.4)
   coveralls
+  database_cleaner-active_record
   debug
   factory_bot_rails
   faker

app/controllers/api/v1/participants_controller.rb

@@ -1,11 +1,6 @@
 class Api::V1::ParticipantsController < ApplicationController
   include ParticipantsHelper
 
-  # Returns true if the user has TA privileges; otherwise, denies access by returning false.
-  def action_allowed?
-    has_required_role?('Teaching Assistant')
-  end
-
   # Return a list of participants for a given user
   # params - user_id
   # GET /participants/user/:user_id

app/controllers/api/v1/questions_controller.rb

@@ -29,6 +29,15 @@ def show
     end
   end
 
+  # GET /api/v1/questions/show_all/questionnaire/:id
+  def show_all
+    questionnaire = Questionnaire.find(params[:id])
+    items = questionnaire.items.order(:id)
+    render json: items, status: :ok
+  rescue ActiveRecord::RecordNotFound
+    render json: { error: "Couldn't find Questionnaire" }, status: :not_found
+  end
+
   # POST /questions
   def create
     questionnaire_id = params[:questionnaire_id]
@@ -72,7 +81,33 @@ def update
       render json: { error: @item.errors.full_messages.to_sentence }, status: :unprocessable_entity
     end
   end
-  
+
+  def destroy
+    @item = Item.find(params[:id])
+    @item.destroy
+    head :no_content
+  rescue ActiveRecord::RecordNotFound
+    render json: { error: "Couldn't find Item" }, status: :not_found
+  end
+
+  # DELETE /api/v1/questions/delete_all/questionnaire/:id
+  def delete_all
+    questionnaire = Questionnaire.find(params[:id])
+    if questionnaire.items.delete_all
+      render json: { message: "All questions deleted" }, status: :ok
+    else
+      render json: { error: "Deletion failed" }, status: :unprocessable_entity
+    end
+  rescue ActiveRecord::RecordNotFound
+    render json: { error: "Couldn't find Questionnaire" }, status: :not_found
+  end
+
+  def types
+    types = Item.pluck(:question_type).uniq
+    render json: types, status: :ok
+  end
+
+
   private
 
   def set_question

app/models/Item.rb

@@ -1,8 +1,7 @@
 class Item < ApplicationRecord
   before_create :set_seq
   belongs_to :questionnaire # each item belongs to a specific questionnaire
-  has_many :answers, dependent: :destroy
-  has_many :choices, dependent: :destroy
+  has_many :answers, dependent: :destroy, foreign_key: 'question_id'
   attr_accessor :choice_strategy
 
   validates :seq, presence: true, numericality: true # sequence must be numeric

app/models/Strategies/scale_strategy.rb

@@ -2,7 +2,7 @@ module Strategies
   class ScaleStrategy < ChoiceStrategy
     def render(item)
       # Render scale (numeric sequence of options)
-      item.alternatives.map { |alt| "<option value='#{alt}'>#{alt}</option>" }.join
+      (item.alternatives || []).map { |alt| "<option value='#{alt}'>#{alt}</option>" }.join
     end
 
     def validate(item)

app/models/assignment.rb

@@ -9,7 +9,7 @@ class Assignment < ApplicationRecord
   has_many :response_maps, foreign_key: 'reviewed_object_id', dependent: :destroy, inverse_of: :assignment
   has_many :review_mappings, class_name: 'ReviewResponseMap', foreign_key: 'reviewed_object_id', dependent: :destroy, inverse_of: :assignment
   has_many :sign_up_topics , class_name: 'SignUpTopic', foreign_key: 'assignment_id', dependent: :destroy
-  has_many :due_dates, class_name: 'DueDate', foreign_key: 'due_date_id', dependent: :destroy, as: :parent
+  has_many :due_dates,as: :parent, class_name: 'DueDate',  dependent: :destroy, as: :parent
   belongs_to :course, optional: true
   belongs_to :instructor, class_name: 'User', inverse_of: :assignments
 

app/models/role.rb

@@ -64,6 +64,7 @@ def other_roles
   end
 
   def as_json(options = nil)
+    options = options || {} # Ensure options is a hash
     super(options.merge({ only: %i[id name parent_id] }))
   end
 end

app/models/sign_up_topic.rb

@@ -2,6 +2,6 @@ class SignUpTopic < ApplicationRecord
   has_many :signed_up_teams, foreign_key: 'topic_id', dependent: :destroy
   has_many :teams, through: :signed_up_teams # list all teams choose this topic, no matter in waitlist or not
   has_many :assignment_questionnaires, class_name: 'AssignmentQuestionnaire', foreign_key: 'topic_id', dependent: :destroy
-  has_many :due_dates, class_name: 'DueDate', foreign_key: 'due_date_id', dependent: :destroy, as: :parent
+  has_many :due_dates, as: :parent,class_name: 'DueDate', dependent: :destroy, as: :parent
   belongs_to :assignment
 end