do i need run-java.sh any more when my jdk version using jdk17

[feofefo]

[rhuss]

Probably not. The primary value of run-java.sh was to help get proper defaults for the Java 8 version before those got fixed. Java is much better these days when it comes to "container-awareness". Also, run-java.sh is not maintained actively, so I recommend moving away. It had its time, but now it's probably obsolete.

[feofefo]

ok, thank you so much.

[grgrzybek]

While #113 is attempting (not fully) to detect Cgroups v2, which is well handled/supported by JDK17 (and JDK 1.8 too for some time now), JVM sets the {{MaxHeapSize}} to 1/4 of max available memory. If we want more, we need -Xmx and run-java.sh is supposed to help with the calculations (for example with declarative {{JAVA_MAX_MEM_RATIO}}).

But {{run-java.sh}} is not only for detecting default mem/cpu settings. It also handles debugging options in quite standard way, handles standard support scripts (like {{run-env.sh}}) and does some detection about Java application/jar to run.