Skip to content

Commit ca57948

Browse files
hoxyqfacebook-github-bot
authored andcommitted
Change visibility of tracing methods for RuntimeTarget (#54281)
Summary: # Changelog: [Internal] This is not used, nor required. The controller is the canonical way of using targets. Reviewed By: huntie Differential Revision: D85440639
1 parent 3ff4ab2 commit ca57948

File tree

1 file changed

+12
-13
lines changed

1 file changed

+12
-13
lines changed

packages/react-native/ReactCommon/jsinspector-modern/RuntimeTarget.h

Lines changed: 12 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -207,19 +207,6 @@ class JSINSPECTOR_EXPORT RuntimeTarget : public EnableExecutorFromThis<RuntimeTa
207207
*/
208208
std::shared_ptr<RuntimeTracingAgent> createTracingAgent(tracing::TraceRecordingState &state);
209209

210-
/**
211-
* Start sampling profiler for a particular JavaScript runtime.
212-
*/
213-
void enableSamplingProfiler();
214-
/**
215-
* Stop sampling profiler for a particular JavaScript runtime.
216-
*/
217-
void disableSamplingProfiler();
218-
/**
219-
* Return recorded sampling profile for the previous sampling session.
220-
*/
221-
tracing::RuntimeSamplingProfile collectSamplingProfile();
222-
223210
private:
224211
using Domain = RuntimeTargetController::Domain;
225212

@@ -275,6 +262,18 @@ class JSINSPECTOR_EXPORT RuntimeTarget : public EnableExecutorFromThis<RuntimeTa
275262
* session - HostTargetTraceRecording.
276263
*/
277264
std::weak_ptr<RuntimeTracingAgent> tracingAgent_;
265+
/**
266+
* Start sampling profiler for a particular JavaScript runtime.
267+
*/
268+
void enableSamplingProfiler();
269+
/**
270+
* Stop sampling profiler for a particular JavaScript runtime.
271+
*/
272+
void disableSamplingProfiler();
273+
/**
274+
* Return recorded sampling profile for the previous sampling session.
275+
*/
276+
tracing::RuntimeSamplingProfile collectSamplingProfile();
278277

279278
/**
280279
* Adds a function with the given name on the runtime's global object, that

0 commit comments

Comments
 (0)