Skip to content

Commit b622cf1

Browse files
authored
chore(ruby): Clean up calls to resolve the root module name. (#9503)
Clean up calls to resolve the root module name
1 parent c6d7ecf commit b622cf1

File tree

10 files changed

+25
-21
lines changed

10 files changed

+25
-21
lines changed

generators/ruby-v2/base/src/context/AbstractRubyGeneratorContext.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,9 +59,13 @@ export abstract class AbstractRubyGeneratorContext<
5959
});
6060
}
6161

62+
public getRootModuleName(): string {
63+
return capitalize(this.getRootFolderName());
64+
}
65+
6266
public getRootModule(): ruby.Module_ {
6367
return ruby.module({
64-
name: capitalize(this.getRootFolderName()),
68+
name: this.getRootModuleName(),
6569
statements: []
6670
});
6771
}

generators/ruby-v2/base/src/project/RubyProject.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -201,7 +201,7 @@ class GemspecFile {
201201

202202
public async toString(): Promise<string> {
203203
const moduleFolderName = this.context.getRootFolderName();
204-
const moduleName = this.context.getRootModule().name;
204+
const moduleName = this.context.getRootModuleName();
205205

206206
return dedent`
207207
# frozen_string_literal: true
@@ -262,7 +262,7 @@ class CustomGemspecFile {
262262
}
263263
264264
public async toString(): Promise<string> {
265-
const moduleName = this.context.getRootModule().name;
265+
const moduleName = this.context.getRootModuleName();
266266
267267
return dedent`
268268
# frozen_string_literal: true
@@ -436,7 +436,7 @@ class VersionFile {
436436
}
437437

438438
public toString(): string {
439-
const seedName = this.context.getRootModule().name;
439+
const seedName = this.context.getRootModuleName();
440440
const version = this.context.getVersionFromConfig();
441441

442442
return dedent`

generators/ruby-v2/model/src/ModelGeneratorContext.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ export class ModelGeneratorContext extends AbstractRubyGeneratorContext<ModelCus
3535

3636
public getModuleNamesForTypeId(typeId: TypeId): string[] {
3737
const typeDeclaration = this.getTypeDeclarationOrThrow(typeId);
38-
return [this.getRootModule().name, ...this.pascalNames(typeDeclaration), this.getTypesModule().name];
38+
return [this.getRootModuleName(), ...this.pascalNames(typeDeclaration), this.getTypesModule().name];
3939
}
4040

4141
public getModulesForTypeId(typeId: TypeId): ruby.Module_[] {

generators/ruby-v2/model/src/enum/EnumGenerator.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ export class EnumGenerator extends FileGenerator<RubyFile, ModelCustomConfigSche
2727
const enumModule = ruby.module({
2828
name: this.typeDeclaration.name.name.pascalCase.safeName
2929
});
30-
enumModule.addStatement(ruby.codeblock(`extend ${this.context.getRootModule().name}::Internal::Types::Enum`));
30+
enumModule.addStatement(ruby.codeblock(`extend ${this.context.getRootModuleName()}::Internal::Types::Enum`));
3131

3232
for (const enumValue of this.enumDeclaration.values) {
3333
enumModule.addStatement(

generators/ruby-v2/model/src/union/UnionGenerator.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ export class UnionGenerator extends FileGenerator<RubyFile, ModelCustomConfigSch
4040
superclass: this.context.getModelClassReference(),
4141
docstring: this.typeDeclaration.docs ?? undefined
4242
});
43-
classNode.addStatement(ruby.codeblock(`extend ${this.context.getRootModule().name}::Internal::Types::Union`));
43+
classNode.addStatement(ruby.codeblock(`extend ${this.context.getRootModuleName()}::Internal::Types::Union`));
4444

4545
classNode.addStatement(
4646
ruby.codeblock((writer) => {

generators/ruby-v2/sdk/src/SdkGeneratorContext.ts

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ export class SdkGeneratorContext extends AbstractRubyGeneratorContext<SdkCustomC
7979

8080
public getModuleNamesForTypeId(typeId: TypeId): string[] {
8181
const typeDeclaration = this.getTypeDeclarationOrThrow(typeId);
82-
return [this.getRootModule().name, ...this.pascalNames(typeDeclaration), this.getTypesModule().name];
82+
return [this.getRootModuleName(), ...this.pascalNames(typeDeclaration), this.getTypesModule().name];
8383
}
8484

8585
public getModulesForTypeId(typeId: TypeId): ruby.Module_[] {
@@ -146,15 +146,15 @@ export class SdkGeneratorContext extends AbstractRubyGeneratorContext<SdkCustomC
146146
public getRawClientClassReference(): ClassReference {
147147
return ruby.classReference({
148148
name: "RawClient",
149-
modules: [this.getRootModule().name, "Internal", "Http"],
149+
modules: [this.getRootModuleName(), "Internal", "Http"],
150150
fullyQualified: true
151151
});
152152
}
153153

154154
public getEnvironmentsClassReference(): ruby.ClassReference {
155155
return ruby.classReference({
156156
name: "Environment",
157-
modules: [this.getRootModule().name]
157+
modules: [this.getRootModuleName()]
158158
});
159159
}
160160

@@ -176,7 +176,7 @@ export class SdkGeneratorContext extends AbstractRubyGeneratorContext<SdkCustomC
176176
// Return the class reference, performing the same casing as the SingleUrlEnvironmentGenerator
177177
return ruby.classReference({
178178
name: defaultEnvironment.name.screamingSnakeCase.safeName,
179-
modules: [this.getRootModule().name, "Environment"]
179+
modules: [this.getRootModuleName(), "Environment"]
180180
});
181181
}
182182

@@ -187,14 +187,14 @@ export class SdkGeneratorContext extends AbstractRubyGeneratorContext<SdkCustomC
187187
public getReferenceToInternalJSONRequest(): ruby.ClassReference {
188188
return ruby.classReference({
189189
name: "Request",
190-
modules: [this.getRootModule().name, "Internal", "JSON"]
190+
modules: [this.getRootModuleName(), "Internal", "JSON"]
191191
});
192192
}
193193

194194
public getReferenceToInternalMultipartRequest(): ruby.ClassReference {
195195
return ruby.classReference({
196196
name: "Request",
197-
modules: [this.getRootModule().name, "Internal", "Multipart"]
197+
modules: [this.getRootModuleName(), "Internal", "Multipart"]
198198
});
199199
}
200200

@@ -203,7 +203,7 @@ export class SdkGeneratorContext extends AbstractRubyGeneratorContext<SdkCustomC
203203
return ruby.classReference({
204204
name: typeDeclaration.name.name.pascalCase.safeName,
205205
modules: [
206-
this.getRootModule().name,
206+
this.getRootModuleName(),
207207
...typeDeclaration.name.fernFilepath.allParts.map((path) => path.pascalCase.safeName),
208208
"Types"
209209
]
@@ -212,7 +212,7 @@ export class SdkGeneratorContext extends AbstractRubyGeneratorContext<SdkCustomC
212212

213213
public getModuleNamesForServiceId(serviceId: ServiceId): string[] {
214214
return [
215-
this.getRootModule().name,
215+
this.getRootModuleName(),
216216
...this.getSubpackageForServiceId(serviceId).fernFilepath.allParts.map((part) => part.pascalCase.safeName),
217217
this.getTypesModule().name
218218
];

generators/ruby-v2/sdk/src/endpoint/http/HttpEndpointGenerator.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ export class HttpEndpointGenerator {
8686
body: ruby.raise({
8787
errorClass: ruby.classReference({
8888
name: "TimeoutError",
89-
modules: [this.context.getRootModule().name, "Errors"]
89+
modules: [this.context.getRootModuleName(), "Errors"]
9090
})
9191
})
9292
}
@@ -120,7 +120,7 @@ export class HttpEndpointGenerator {
120120
]
121121
},
122122
elseBody: ruby.codeblock((writer) => {
123-
const rootModuleName = this.context.getRootModule().name;
123+
const rootModuleName = this.context.getRootModuleName();
124124
writer.writeLine(
125125
`${ERROR_CLASS_VN} = ${rootModuleName}::Errors::ResponseError.subclass_for_code(${CODE_VN})`
126126
);

generators/ruby-v2/sdk/src/readme/ReadmeSnippetBuilder.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ export class ReadmeSnippetBuilder extends AbstractReadmeSnippetBuilder {
4343
? this.context.ir.readmeConfig.defaultEndpoint
4444
: this.getDefaultEndpointId();
4545
this.rootPackageName = this.context.getRootFolderName();
46-
this.rootPackageClientName = this.context.getRootModule().name;
46+
this.rootPackageClientName = this.context.getRootModuleName();
4747
}
4848

4949
public buildReadmeSnippetsByFeatureId(): Record<FernGeneratorCli.FeatureId, string[]> {

generators/ruby-v2/sdk/src/root-client/RootClientGenerator.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ export class RootClientGenerator extends FileGenerator<RubyFile, SdkCustomConfig
7070
returnType: ruby.Type.class_(
7171
ruby.classReference({
7272
name: "Client",
73-
modules: [this.context.getRootModule().name],
73+
modules: [this.context.getRootModuleName()],
7474
fullyQualified: true
7575
})
7676
)

generators/ruby-v2/sdk/src/subpackage-client/SubPackageClientGenerator.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ export class SubPackageClientGenerator extends FileGenerator<RubyFile, SdkCustom
8282

8383
private getClientModuleNames(): string[] {
8484
return [
85-
this.context.getRootModule().name,
85+
this.context.getRootModuleName(),
8686
...this.subpackage.fernFilepath.allParts.map((path) => path.pascalCase.safeName)
8787
];
8888
}
@@ -95,7 +95,7 @@ export class SubPackageClientGenerator extends FileGenerator<RubyFile, SdkCustom
9595
return ruby.classReference({
9696
name: CLIENT_CLASS_NAME,
9797
modules: [
98-
this.context.getRootModule().name,
98+
this.context.getRootModuleName(),
9999
...this.subpackage.fernFilepath.allParts.map((path) => path.pascalCase.safeName)
100100
],
101101
fullyQualified: true

0 commit comments

Comments
 (0)