ci: compatibility and formatting fixes #91
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmartinv
changed the title
kgiusti
reviewed
Oct 20, 2025
kgiusti
reviewed
Oct 20, 2025
Signed-off-by: Miguel Martín <[email protected]>
Signed-off-by: Miguel Martín <[email protected]>
Signed-off-by: Miguel Martín <[email protected]>
Use `./test/workdir` as the default `base_dir` instead of `/tmp/go-fdo` as the directory where the test files will be created. Configure the container's working dir through the `working_dir` variable (default: `/workdir`) Signed-off-by: Miguel Martín <[email protected]>
Create the temp files in the upload destination folder instead of `/tmp` to avoid "invalid cross-device link" errors. Signed-off-by: Miguel Martín <[email protected]>
That was fixed on client side by creating the temporary file in the final destination dir: fido-device-onboard/go-fdo-client@9ac6738 Pretty much the same I am proposing on this PR for the server side :) |
kgiusti
reviewed
Oct 22, 2025
| uninstall_server | ||
| uninstall_client | ||
| rm -rf "${base_dir}" | ||
| rm -rf "${base_dir:?}"/* |
There was a problem hiding this comment.
Oh, yes this is indeed a good change 🥇
kgiusti
approved these changes
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.