Second round of comments

Author: damiano-flex

docs/lectures/index.rst

@@ -10,10 +10,8 @@ Welcome to our lecture series!
     fdtd101
     fdtd_workshop
     inversedesign
-    small_signal_analysis
 
 
 .. include:: /lectures/fdtd101.rst
 .. include:: /lectures/fdtd_workshop.rst
 .. include:: /lectures/inversedesign.rst
-.. include:: /lectures/small_signal_analysis.rst

docs/lectures/small_signal_analysis.rst

@@ -4,10 +4,6 @@
     "ACVoltageSource": {
       "additionalProperties": false,
       "properties": {
-        "amplitude": {
-          "default": 1.0,
-          "type": "number"
-        },
         "attrs": {
           "default": {},
           "type": "object"
@@ -16,6 +12,19 @@
           "minLength": 1,
           "type": "string"
         },
+        "signal": {
+          "allOf": [
+            {
+              "$ref": "#/definitions/SinusoidalSignal"
+            }
+          ],
+          "default": {
+            "amplitude": 1.0,
+            "attrs": {},
+            "frequency": null,
+            "type": "SinusoidalSignal"
+          }
+        },
         "type": {
           "default": "ACVoltageSource",
           "enum": [
@@ -4539,6 +4548,58 @@
       },
       "type": "object"
     },
+    "IsothermalSSACAnalysis": {
+      "additionalProperties": false,
+      "properties": {
+        "attrs": {
+          "default": {},
+          "type": "object"
+        },
+        "convergence_dv": {
+          "default": 1.0,
+          "exclusiveMinimum": 0,
+          "type": "number"
+        },
+        "fermi_dirac": {
+          "default": false,
+          "type": "boolean"
+        },
+        "ssac_freqs": {
+          "type": "ArrayLike"
+        },
+        "temperature": {
+          "default": 300,
+          "exclusiveMinimum": 0,
+          "type": "number"
+        },
+        "tolerance_settings": {
+          "allOf": [
+            {
+              "$ref": "#/definitions/ChargeToleranceSpec"
+            }
+          ],
+          "default": {
+            "abs_tol": 10000000000.0,
+            "attrs": {},
+            "max_iters": 30,
+            "ramp_up_iters": 1,
+            "rel_tol": 1e-10,
+            "type": "ChargeToleranceSpec"
+          }
+        },
+        "type": {
+          "default": "IsothermalSSACAnalysis",
+          "enum": [
+            "IsothermalSSACAnalysis"
+          ],
+          "type": "string"
+        }
+      },
+      "required": [
+        "ssac_freqs"
+      ],
+      "type": "object"
+    },
     "IsothermalSteadyChargeDCAnalysis": {
       "additionalProperties": false,
       "properties": {
@@ -7077,6 +7138,31 @@
       },
       "type": "object"
     },
+    "SinusoidalSignal": {
+      "additionalProperties": false,
+      "properties": {
+        "amplitude": {
+          "default": 1.0,
+          "type": "number"
+        },
+        "attrs": {
+          "default": {},
+          "type": "object"
+        },
+        "frequency": {
+          "exclusiveMinimum": 0,
+          "type": "number"
+        },
+        "type": {
+          "default": "SinusoidalSignal",
+          "enum": [
+            "SinusoidalSignal"
+          ],
+          "type": "string"
+        }
+      },
+      "type": "object"
+    },
     "SlotboomBandGapNarrowing": {
       "additionalProperties": false,
       "properties": {
@@ -9541,6 +9627,9 @@
   "properties": {
     "analysis_spec": {
       "anyOf": [
+        {
+          "$ref": "#/definitions/IsothermalSSACAnalysis"
+        },
         {
           "$ref": "#/definitions/IsothermalSteadyChargeDCAnalysis"
         },

schemas/HeatChargeSimulation.json

@@ -4,10 +4,6 @@
     "ACVoltageSource": {
       "additionalProperties": false,
       "properties": {
-        "amplitude": {
-          "default": 1.0,
-          "type": "number"
-        },
         "attrs": {
           "default": {},
           "type": "object"
@@ -16,6 +12,19 @@
           "minLength": 1,
           "type": "string"
         },
+        "signal": {
+          "allOf": [
+            {
+              "$ref": "#/definitions/SinusoidalSignal"
+            }
+          ],
+          "default": {
+            "amplitude": 1.0,
+            "attrs": {},
+            "frequency": null,
+            "type": "SinusoidalSignal"
+          }
+        },
         "type": {
           "default": "ACVoltageSource",
           "enum": [
@@ -4539,6 +4548,58 @@
       },
       "type": "object"
     },
+    "IsothermalSSACAnalysis": {
+      "additionalProperties": false,
+      "properties": {
+        "attrs": {
+          "default": {},
+          "type": "object"
+        },
+        "convergence_dv": {
+          "default": 1.0,
+          "exclusiveMinimum": 0,
+          "type": "number"
+        },
+        "fermi_dirac": {
+          "default": false,
+          "type": "boolean"
+        },
+        "ssac_freqs": {
+          "type": "ArrayLike"
+        },
+        "temperature": {
+          "default": 300,
+          "exclusiveMinimum": 0,
+          "type": "number"
+        },
+        "tolerance_settings": {
+          "allOf": [
+            {
+              "$ref": "#/definitions/ChargeToleranceSpec"
+            }
+          ],
+          "default": {
+            "abs_tol": 10000000000.0,
+            "attrs": {},
+            "max_iters": 30,
+            "ramp_up_iters": 1,
+            "rel_tol": 1e-10,
+            "type": "ChargeToleranceSpec"
+          }
+        },
+        "type": {
+          "default": "IsothermalSSACAnalysis",
+          "enum": [
+            "IsothermalSSACAnalysis"
+          ],
+          "type": "string"
+        }
+      },
+      "required": [
+        "ssac_freqs"
+      ],
+      "type": "object"
+    },
     "IsothermalSteadyChargeDCAnalysis": {
       "additionalProperties": false,
       "properties": {
@@ -7077,6 +7138,31 @@
       },
       "type": "object"
     },
+    "SinusoidalSignal": {
+      "additionalProperties": false,
+      "properties": {
+        "amplitude": {
+          "default": 1.0,
+          "type": "number"
+        },
+        "attrs": {
+          "default": {},
+          "type": "object"
+        },
+        "frequency": {
+          "exclusiveMinimum": 0,
+          "type": "number"
+        },
+        "type": {
+          "default": "SinusoidalSignal",
+          "enum": [
+            "SinusoidalSignal"
+          ],
+          "type": "string"
+        }
+      },
+      "type": "object"
+    },
     "SlotboomBandGapNarrowing": {
       "additionalProperties": false,
       "properties": {
@@ -9541,6 +9627,9 @@
   "properties": {
     "analysis_spec": {
       "anyOf": [
+        {
+          "$ref": "#/definitions/IsothermalSSACAnalysis"
+        },
         {
           "$ref": "#/definitions/IsothermalSteadyChargeDCAnalysis"
         },