Skip to content

Conversation

@MaxAtoms
Copy link
Collaborator

@MaxAtoms MaxAtoms self-assigned this Nov 10, 2025
@MaxAtoms
Copy link
Collaborator Author

I think this main Vitest config is only relevant when running tests from the IDE or via npx vitest, right?
Our npm run-scripts directly reference the sub-configs

@EagleoutIce
Copy link
Member

Is it deprecated? yes. Does it harm modern systems? afaik no.
But @gigalasr and others reported problems with vite without having a fallback workspace to work on! So please recheck @gigalasr or add to this

@EagleoutIce
Copy link
Member

EagleoutIce commented Nov 10, 2025

And even though we use npm runs, people still want to use the IDE runners, but let's have the people with problems (maybe @Ellpeck was one of them) have a look at this and see whether this also resolves the problem.

But given that it apprently works for you @MaxAtoms maybe it works for the others too :D

@MaxAtoms
Copy link
Collaborator Author

My commit message might have been a bit confusing 😬 This is not removing the settings from the workspace file, but rather replace them with a configuration that is compatible with Vitest 4.
The behavior should be the same as far as my testing goes.

@MaxAtoms MaxAtoms changed the title tests-fix(deps): remove deprecated vitest workspace Replace deprecated Vitest workspace with config Nov 10, 2025
@EagleoutIce
Copy link
Member

Jeah sorry I've seen that when looking at the changes too, but I would still want the others to check (at least @gigalasr) to see whether it works with the new format!

@gigalasr
Copy link
Collaborator

gigalasr commented Nov 11, 2025

On this branch I get the following error when opening the project in vscode:
image

@gigalasr
Copy link
Collaborator

gigalasr commented Nov 11, 2025

Actually after updating and restarting the extension and vscode, and reinstalling all node modules the problem is gone :D

@EagleoutIce
Copy link
Member

allright this is mergeable then :D

@EagleoutIce EagleoutIce merged commit cf48880 into main Nov 11, 2025
17 checks passed
@EagleoutIce EagleoutIce deleted the vitest-workspace-deprecated branch November 11, 2025 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants