Skip to content

Commit a6405ff

Browse files
committed
Use PluginLogger for coverage
1 parent 7518324 commit a6405ff

File tree

2 files changed

+27
-4
lines changed

2 files changed

+27
-4
lines changed

src/io/flutter/run/coverage/FlutterCoverageProgramRunner.java

Lines changed: 16 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,9 @@
2424
import com.intellij.openapi.vfs.LocalFileSystem;
2525
import com.intellij.openapi.vfs.VfsUtil;
2626
import io.flutter.FlutterBundle;
27+
import io.flutter.logging.PluginLogger;
2728
import io.flutter.run.test.TestConfig;
29+
import io.flutter.settings.FlutterSettings;
2830
import io.flutter.utils.OpenApiUtils;
2931
import org.jetbrains.annotations.NonNls;
3032
import org.jetbrains.annotations.NotNull;
@@ -33,9 +35,10 @@
3335
import java.nio.file.Files;
3436
import java.nio.file.Path;
3537
import java.nio.file.Paths;
38+
import java.util.Objects;
3639

3740
public class FlutterCoverageProgramRunner extends GenericProgramRunner<RunnerSettings> {
38-
private static final @NotNull Logger LOG = Logger.getInstance(FlutterCoverageProgramRunner.class.getName());
41+
private static final @NotNull Logger LOG = PluginLogger.createLogger(FlutterCoverageProgramRunner.class);
3942

4043
private static final String ID = "FlutterCoverageProgramRunner";
4144
private ProcessHandler handler;
@@ -96,9 +99,20 @@ private void processCoverage(ExecutionEnvironment env) {
9699
handler = null;
97100
listener = null;
98101
}
102+
LOG.error(FlutterBundle.message("coverage.path.not.found", "test_" + getSafePath(path)));
99103
}
100104
else {
101-
LOG.error(FlutterBundle.message("coverage.path.not.found", path));
105+
LOG.error(FlutterBundle.message("coverage.path.not.found", getSafePath(path)));
102106
}
103107
}
108+
109+
private @NotNull String getSafePath(@NotNull Path path) {
110+
if (FlutterSettings.getInstance().isFilePathLoggingEnabled()) {
111+
return path.toString();
112+
}
113+
114+
if (path.getNameCount() == 0) return "";
115+
116+
return Objects.requireNonNull(path.getFileName()).toString();
117+
}
104118
}

src/io/flutter/run/coverage/FlutterCoverageRunner.java

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@
1111
import com.intellij.openapi.diagnostic.Logger;
1212
import com.intellij.rt.coverage.data.ProjectData;
1313
import io.flutter.FlutterBundle;
14+
import io.flutter.logging.PluginLogger;
15+
import io.flutter.settings.FlutterSettings;
1416
import org.jetbrains.annotations.NotNull;
1517
import org.jetbrains.annotations.Nullable;
1618

@@ -19,7 +21,8 @@
1921

2022
public class FlutterCoverageRunner extends CoverageRunner {
2123
private static final String ID = "FlutterCoverageRunner";
22-
private static final @NotNull Logger LOG = Logger.getInstance(FlutterCoverageRunner.class.getName());
24+
private static final @NotNull Logger LOG = PluginLogger.createLogger(FlutterCoverageRunner.class);
25+
private static @NotNull Logger log;
2326

2427
@Nullable
2528
@Override
@@ -35,9 +38,15 @@ private static ProjectData doLoadCoverageData(@NotNull final File sessionDataFil
3538
final ProjectData projectData = new ProjectData();
3639
try {
3740
LcovInfo.readInto(projectData, sessionDataFile);
41+
log.warn(FlutterBundle.message("coverage.data.not.read", "test_" + (FlutterSettings.getInstance().isFilePathLoggingEnabled()
42+
? sessionDataFile.getAbsolutePath()
43+
: sessionDataFile.getName())));
44+
3845
}
3946
catch (IOException ex) {
40-
LOG.warn(FlutterBundle.message("coverage.data.not.read", sessionDataFile.getAbsolutePath()));
47+
log.warn(FlutterBundle.message("coverage.data.not.read", FlutterSettings.getInstance().isFilePathLoggingEnabled()
48+
? sessionDataFile.getAbsolutePath()
49+
: sessionDataFile.getName()));
4150
return null;
4251
}
4352
return projectData;

0 commit comments

Comments
 (0)