Skip to content

Commit e619ef4

Browse files
authored
[CQ] DeviceDaemon: remove unnecessary suppression (#8508)
Removes redundant suppression. <img width="900" height="164" alt="image" src="https://github.com/user-attachments/assets/595c7f5b-e7d9-42bd-9d42-1f0f5fb336a2" /> --- <details> <summary>Contribution guidelines:</summary><br> - See our [contributor guide]([https://github.com/dart-lang/sdk/blob/main/CONTRIBUTING.md](https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview) for general expectations for PRs. - Larger or significant changes should be discussed in an issue before creating a PR. - Dart contributions to our repos should follow the [Dart style guide](https://dart.dev/guides/language/effective-dart) and use `dart format`. - Java and Kotlin contributions should strive to follow Java and Kotlin best practices ([discussion](#8098)). </details>
1 parent c3b366f commit e619ef4

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

src/io/flutter/run/daemon/DeviceDaemon.java

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,11 @@
4141
import java.util.ArrayList;
4242
import java.util.Comparator;
4343
import java.util.List;
44-
import java.util.concurrent.*;
44+
import java.util.concurrent.CancellationException;
45+
import java.util.concurrent.CompletableFuture;
46+
import java.util.concurrent.Future;
47+
import java.util.concurrent.TimeUnit;
48+
import java.util.concurrent.TimeoutException;
4549
import java.util.concurrent.atomic.AtomicBoolean;
4650
import java.util.concurrent.atomic.AtomicInteger;
4751
import java.util.concurrent.atomic.AtomicReference;
@@ -117,7 +121,8 @@ boolean needRestart(@NotNull Command next) {
117121
*/
118122
void shutdown() {
119123
if (!process.isProcessTerminated()) {
120-
LOG.info("shutting down Flutter device daemon #" + id + ": " + command.toString(FlutterSettings.getInstance().isFilePathLoggingEnabled()));
124+
LOG.info(
125+
"shutting down Flutter device daemon #" + id + ": " + command.toString(FlutterSettings.getInstance().isFilePathLoggingEnabled()));
121126
}
122127
listener.running.set(false);
123128
process.destroyProcess();
@@ -209,7 +214,6 @@ DeviceDaemon start(Supplier<Boolean> isCancelled,
209214
Runnable deviceChanged,
210215
Consumer<String> processStopped) throws ExecutionException {
211216
final int daemonId = nextDaemonId.incrementAndGet();
212-
//noinspection UnnecessaryToStringCall
213217
LOG.info("starting Flutter device daemon #" + daemonId + ": " + toString(FlutterSettings.getInstance().isFilePathLoggingEnabled()));
214218
// The mostly silent process handler reduces CPU usage of the daemon process.
215219
final ProcessHandler process = new MostlySilentColoredProcessHandler(toCommandLine());

0 commit comments

Comments
 (0)