Make flycheck-pos-tip-hide-messages work without minor mode #37
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way, the package works as expected even when the user enables it
by customizing
flycheck-display-errors-function(or happens to savesuch a customization permanently after enabling
flycheck-pos-tip-mode).Fix #36.
The new implementation strategy is to add
flycheck-pos-tip-hide-messagesto the appropriate hooks temporarilywhen the display function is called, and remove it when the messages
are actually dismissed. This avoids depending on the minor mode being
enabled at all.
Now, the only job of the minor mode is to be able to interactively
toggle the value of
flycheck-display-errors-function.