feat: handle already deleted stack (#21)

* feat(stack): handle metadata on update,create

* chore: remove metadata log

* feat: handle already deleted stack

Author: Dav-14

internal/resources/stack.go

@@ -3,6 +3,7 @@ package resources
 import (
 	"context"
 	"fmt"
+	"net/http"
 
 	"github.com/formancehq/go-libs/v3/logging"
 	"github.com/formancehq/go-libs/v3/pointer"
@@ -229,6 +230,14 @@ func (s *Stack) Delete(ctx context.Context, req resource.DeleteRequest, resp *re
 	}
 	res, err := s.store.GetSDK().DeleteStack(ctx, organizationId, plan.GetID(), plan.ForceDestroy.ValueBool())
 	if err != nil {
+		if res.StatusCode == http.StatusNotFound {
+			resp.Diagnostics.AddWarning(
+				"Stack not found",
+				"The stack was not found. It may have already been deleted outside of Terraform.",
+			)
+			return
+		}
+
 		pkg.HandleSDKError(ctx, err, res, &resp.Diagnostics)
 		return
 	}

tests/integration/stack_test.go

@@ -1,6 +1,7 @@
 package integration_test
 
 import (
+	"errors"
 	"fmt"
 	"net/http"
 	"testing"
@@ -120,3 +121,107 @@ func TestStack(t *testing.T) {
 		})
 	}
 }
+
+func TestStackAlreadyDeleted(t *testing.T) {
+	t.Parallel()
+	type testCase struct {
+		step          []resource.TestStep
+		expectedCalls func(*pkg.MockCloudSDK, *pkg.MockTokenProviderImpl)
+	}
+
+	for i, tc := range []testCase{
+		{
+			step: []resource.TestStep{
+				{
+					Config: `
+					provider "cloud" {}
+					resource "cloud_stack" "test" {
+						name = "test"
+						region_id = "staging"
+						metadata = {
+							"env" = "test"
+						}
+						force_destroy = true
+					}
+					`,
+				},
+			},
+			expectedCalls: func(cloudSdk *pkg.MockCloudSDK, tokenProvider *pkg.MockTokenProviderImpl) {
+				organizationID := uuid.NewString()
+				tokenProvider.EXPECT().IntrospectToken(gomock.Any()).Return(oidc.IntrospectionResponse{
+					Claims: map[string]interface{}{
+						"organization_id": organizationID,
+					},
+				}, nil).AnyTimes()
+				stackID := uuid.NewString()
+				cloudSdk.EXPECT().CreateStack(gomock.Any(), organizationID, gomock.Any()).
+					Return(&sdk.CreateStackResponse{
+						Data: &sdk.Stack{
+							Id:             stackID,
+							Name:           "test",
+							OrganizationId: organizationID,
+							RegionID:       "staging",
+							Version:        pointer.For("latest"),
+							Uri:            "https://example.com",
+							Metadata: &map[string]string{
+								"env": "test",
+								"github.com/formancehq/terraform-provider-cloud/protected": "true",
+							},
+						},
+					}, nil, nil)
+				cloudSdk.EXPECT().ReadStack(gomock.Any(), organizationID, stackID).
+					Return(&sdk.CreateStackResponse{
+						Data: &sdk.Stack{
+							Id:             stackID,
+							Name:           "test",
+							OrganizationId: organizationID,
+							RegionID:       "staging",
+							Version:        pointer.For("latest"),
+							Uri:            "https://example.com",
+							Metadata: &map[string]string{
+								"env": "test",
+								"github.com/formancehq/terraform-provider-cloud/protected": "true",
+							},
+						},
+					}, nil, nil)
+				cloudSdk.EXPECT().DeleteStack(gomock.Any(), organizationID, stackID, true).Return(&http.Response{
+					StatusCode: http.StatusNotFound,
+				}, errors.New("stack not found"))
+			},
+		},
+	} {
+
+		t.Run(fmt.Sprintf("test_%d", i), func(t *testing.T) {
+			ctrl := gomock.NewController(t)
+			cloudSdk := pkg.NewMockCloudSDK(ctrl)
+			tokenProvider := pkg.NewMockTokenProviderImpl(ctrl)
+			cloudProvider := server.NewProvider(
+				logging.Testing().WithField("test", fmt.Sprintf("test_%d", i)),
+				server.FormanceCloudEndpoint("dummy-endpoint"),
+				server.FormanceCloudClientId("organization_client_id"),
+				server.FormanceCloudClientSecret("dummy-client-secret"),
+				transport,
+				func(creds pkg.Creds, transport http.RoundTripper) pkg.CloudSDK {
+					return cloudSdk
+				},
+				func(transport http.RoundTripper, creds pkg.Creds) pkg.TokenProviderImpl {
+					return tokenProvider
+				},
+			)
+
+			if tc.expectedCalls != nil {
+				tc.expectedCalls(cloudSdk, tokenProvider)
+			}
+
+			resource.ParallelTest(t, resource.TestCase{
+				ProtoV6ProviderFactories: map[string]func() (tfprotov6.ProviderServer, error){
+					"cloud": providerserver.NewProtocol6WithError(cloudProvider()),
+				},
+				TerraformVersionChecks: []tfversion.TerraformVersionCheck{
+					tfversion.SkipBelow(tfversion.Version0_15_0),
+				},
+				Steps: tc.step,
+			})
+		})
+	}
+}