CI/Lint: Add pyright and isort to the project

Author: ByteOtter

Makefile

@@ -63,6 +63,8 @@ format: install-dev
 
 lint: install-dev
 	$(POETRY) run black --check --extend-exclude test-data/gardenlinux .
+	$(POETRY) run isort --check-only --skip test-data/gardenlinux .
+	$(POETRY) run pyright
 
 security: install-dev
 	@if [ "$(CI)" = "true" ]; then \

poetry.lock

@@ -27,6 +27,8 @@ moto = "^5.1.10"
 python-dotenv = "^1.1.1"
 pytest = "^8.4.1"
 pytest-cov = "^6.2.1"
+isort = "^6.0.1"
+pyright = "^1.1.403"
 
 [tool.poetry.group.docs.dependencies]
 sphinx-rtd-theme = "^3.0.2"
@@ -42,6 +44,17 @@ gl-s3 = "gardenlinux.s3.__main__:main"
 pythonpath = ["src"]
 norecursedirs = "test-data"
 
+[tool.isort]
+profile = "black"
+line_length = 120
+known_first_party = ["gardenlinux"]
+
+[tool.pyright]
+typeCheckingMode = "strict"
+venvPath = "."
+venv = ".venv"
+exclude = ["test-data", "docs", "hack", ".venv", ".pytest-cache", "**/__pycache"]
+
 [build-system]
 requires = ["poetry-core"]
 build-backend = "poetry.core.masonry.api"

pyproject.toml

@@ -0,0 +1,27 @@
+{
+    // Pyright is configured in 'strict' mode in pyproject.toml
+    // This file overrides some reports and tones them down to warnings, if they are not critical.
+    // It also turns some up to become warnings or errors.
+    "reportShadowedImports": "warning",
+    "reportImportCycles": "error",
+    "reportOptionalMemberAccess": "warning",
+    "reportOptionalSubscript": "warning",
+    "reportOptionalContextManager": "warning",
+    "reportOptionalCall": "warning",
+    "reportUnusedVariable": "warning",
+    "reportUnusedImport": "warning",
+    "reportUnusedFunction": "warning",
+    "reportUnusedCallResult": "warning",
+    "reportUnusedClass": "warning",
+    "reportUnnecessaryCast": "warning",
+    "reportUnnecessaryComparison": "warning",
+    "reportUnnecessaryIsInstance": "warning",
+    "reportUnnecessaryContains": "warning",
+    // Becomes useful after introduction of type annotations
+    // "reportUnknownMemberType": "warning",
+    // "reportUnknownParameterType": "warning",
+    // "reportUnknownArgumentType": "warning",
+    // "reportUnknownVariableType": "warning",
+    "reportTypedDictNotRequiredAccess": "error",
+    "reportDeprecated": "warning",
+}