Quality fix

(cherry picked from commit 3526a9b)

Author: sgrampone

gamsaml/src/main/java/com/genexus/saml/SamlHelper.java

@@ -63,13 +63,13 @@ public AuthnRequest createStockAuthnRequest() {
 
 		boolean removeAuthContext = false;
 		String configuredAuthContext = GamSamlProperties.getAuthnContext();
-		if (configuredAuthContext.compareTo("NONE") == 0)
+		if (configuredAuthContext.equals("NONE"))
 			removeAuthContext = true;
 		else {
-			if (configuredAuthContext.compareTo("SMARTCARD_AUTHN_CTX") == 0) {
+			if (configuredAuthContext.equals("SMARTCARD_AUTHN_CTX")) {
 				ref.setAuthnContextClassRef(AuthnContext.SMARTCARD_PKI_AUTHN_CTX);
 				logger.debug("[createStockAuthnRequest] AuthnContext.SMARTCARD_PKI_AUTHN_CTX");
-			} else if (configuredAuthContext.compareTo("PPT_AUTHN_CTX") == 0) {
+			} else if (configuredAuthContext.equals("PPT_AUTHN_CTX")) {
 				ref.setAuthnContextClassRef(AuthnContext.PPT_AUTHN_CTX);
 				logger.debug("[createStockAuthnRequest] AuthnContext.PPT_AUTHN_CTX");
 			} else if (configuredAuthContext.startsWith("urn:oasis:names:tc:SAML:2.0")) {
@@ -123,7 +123,7 @@ public void doAuthenticationRedirect(final HttpServletResponse response) throws
 
 
 		String isRedirectBinding = GamSamlProperties.isRedirectBinding();
-		if (isRedirectBinding.compareTo("true") == 0) {
+		if (isRedirectBinding.equals("true")) {
 			samlEndpoint.setBinding(SAMLConstants.SAML2_REDIRECT_BINDING_URI);
 			logger.debug("[doAuthenticationRedirect] SAMLConstants.SAML2_REDIRECT_BINDING_URI");
 		} else {

gamsaml/src/main/java/com/genexus/saml/SamlReceiver.java

@@ -212,24 +212,14 @@ public boolean validateDetachedSignature(String signature, String document, Stri
 
 
 	private String getAlgorithmCode(String algorithm) {
-		logger.debug("[getAlgorithmCode] algorithm: " + algorithm);
-		String code;
 		if (algorithm.contains("rsa")) {
 			if (algorithm.contains("sha1"))
-				code = "SHA1withRSA";
+				return "SHA1withRSA";
 			else if (algorithm.contains("sha256"))
-				code = "SHA256withRSA";
-			else {
-				logger.debug("[getAlgorithmCode] code not matched: " + algorithm);
-				code = algorithm;
-			}
-
-		} else {
-			logger.debug("[getAlgorithmCode] code not matched: " + algorithm);
-			code = algorithm;
+				return "SHA256withRSA";
 		}
-		logger.debug("[getAlgorithmCode] returned code: " + code);
-		return code;
+		logger.error("[getAlgorithmCode] code not matched: " + algorithm);
+		return algorithm;
 	}