AWS S3: Support for Readonly permissions (#644)

ggallotti · web-flow · commit be7106b7f837 · 2022-12-14T13:27:25.000-03:00
diff --git a/gxexternalproviders/src/main/java/com/genexus/db/driver/ExternalProviderS3.java b/gxexternalproviders/src/main/java/com/genexus/db/driver/ExternalProviderS3.java
@@ -115,7 +115,6 @@ private void initialize() throws Exception{
 
 			this.client = buildS3Client(accessKey, secretKey, endpointValue, region);
 			bucketExists();
-			ensureFolder(folder);
 		}
 	}
 
@@ -276,7 +275,7 @@ public String copy(String objectName, String newName, ResourceAccessControlList
     }
 
     public String copy(String objectUrl, String newName, String tableName, String fieldName, ResourceAccessControlList acl) {
-        String resourceFolderName = ensureFolder(folder, tableName, fieldName);
+        String resourceFolderName = buildPath(folder, tableName, fieldName);
         String resourceKey = resourceFolderName + StorageUtils.DELIMITER + newName;
 
         try {
@@ -371,7 +370,6 @@ public void deleteDirectory(String directoryName) {
     public void renameDirectory(String directoryName, String newDirectoryName) {
         directoryName = StorageUtils.normalizeDirectoryName(directoryName);
         newDirectoryName = StorageUtils.normalizeDirectoryName(newDirectoryName);
-        ensureFolder(newDirectoryName);
         ListObjectsRequest listObjectsRequest = new ListObjectsRequest()
             .withBucketName(bucket).withPrefix(directoryName);
         for (S3ObjectSummary file : client.listObjects(listObjectsRequest).getObjectSummaries()) {

Original file line number	Diff line number	Diff line change
`@@ -115,7 +115,6 @@ private void initialize() throws Exception{`
`115`	`115`
`116`	`116`	`this.client = buildS3Client(accessKey, secretKey, endpointValue, region);`
`117`	`117`	`bucketExists();`
`118`		`- ensureFolder(folder);`
`119`	`118`	`}`
`120`	`119`	`}`
`121`	`120`
`@@ -276,7 +275,7 @@ public String copy(String objectName, String newName, ResourceAccessControlList`
`276`	`275`	`}`
`277`	`276`
`278`	`277`	`public String copy(String objectUrl, String newName, String tableName, String fieldName, ResourceAccessControlList acl) {`
`279`		`- String resourceFolderName = ensureFolder(folder, tableName, fieldName);`
	`278`	`+ String resourceFolderName = buildPath(folder, tableName, fieldName);`
`280`	`279`	`String resourceKey = resourceFolderName + StorageUtils.DELIMITER + newName;`
`281`	`280`
`282`	`281`	`try {`
`@@ -371,7 +370,6 @@ public void deleteDirectory(String directoryName) {`
`371`	`370`	`public void renameDirectory(String directoryName, String newDirectoryName) {`
`372`	`371`	`directoryName = StorageUtils.normalizeDirectoryName(directoryName);`
`373`	`372`	`newDirectoryName = StorageUtils.normalizeDirectoryName(newDirectoryName);`
`374`		`- ensureFolder(newDirectoryName);`
`375`	`373`	`ListObjectsRequest listObjectsRequest = new ListObjectsRequest()`
`376`	`374`	`.withBucketName(bucket).withPrefix(directoryName);`
`377`	`375`	`for (S3ObjectSummary file : client.listObjects(listObjectsRequest).getObjectSummaries()) {`