[Fixes #27] Add MAPSTORE_DEV flag to prod-webpack.config.js for hybrid dev/prod builds #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ig.js for hybrid dev/prod builds Allows developers to build production-ready bundles with development features such as source maps by setting the MAPSTORE_DEV=true environment variable. This is useful for deploying MapStore clients to environments like staging where full debug capability (e.g., unminified code and source maps) is required, while still including all assets (translations, configs, etc.). Example usage from mapstore-client: MAPSTORE_DEV=true mapstore-project compile && node postCompile Changes: - Added `isDevMode` toggle based on MAPSTORE_DEV env var - Conditionally set `mode`, `prod`, `devtool`, and `version` in the build config This avoids the need for a separate dev-focused production build config and keeps the build logic centralised.
allyoucanmap
requested changes
Sep 24, 2025
There was a problem hiding this comment.
Hi @marlowp thanks for the contribution!
The only change I propose here is to use a more specific variable name because MAPSTORE_DEV seems referring to the dev environment.
Thanks for the review @allyoucanmap. Yep agree about the name change. I'll make that update. |
|
@allyoucanmap this should be resolved now. There is an accompanying PR in the geonode-mapstore-client repo that adds the npm command to use this. Are you able to take a look at that one as well? |
allyoucanmap
approved these changes
Oct 7, 2025
|
Thanks @marlowp, merged on master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows developers to build production-ready bundles with development features such as source maps by setting the MAPSTORE_COMPILE_DEV=true environment variable.
This is useful for deploying MapStore clients to environments like staging where full debug capability (e.g., unminified code and source maps) is required, while still including all assets (translations, configs, etc.).
Example usage from mapstore-client:
MAPSTORE_COMPILE_DEV=true mapstore-project compile && node postCompile
Changes:
isCompileDevModetoggle based on MAPSTORE_COMPILE_DEV env varmode,prod,devtool, andversionin the build configThis avoids the need for a separate dev-focused production build config and keeps the build logic centralised.
Closes #27