#134 Fix review comments

- update env variable string parsing
- continue loading files even if some directories are incorrect
- add test for default logic

Author: NivedhaSenthil

getgauge/util.py

@@ -2,7 +2,6 @@
 
 PROJECT_ROOT_ENV = 'GAUGE_PROJECT_ROOT'
 STEP_IMPL_DIR_ENV = 'STEP_IMPL_DIR'
-STEP_IMPL_DIR_NAMES = os.getenv(STEP_IMPL_DIR_ENV).split(',') if os.getenv(STEP_IMPL_DIR_ENV) else ['step_impl']
 
 
 def get_project_root():
@@ -13,6 +12,7 @@ def get_project_root():
 
 
 def get_step_impl_dirs():
+    STEP_IMPL_DIR_NAMES = map(str.strip, os.getenv(STEP_IMPL_DIR_ENV).split(',')) if os.getenv(STEP_IMPL_DIR_ENV) else ['step_impl']
     return [os.path.join(get_project_root(), name) for name in STEP_IMPL_DIR_NAMES]
 
 

start.py

@@ -32,7 +32,6 @@ def load_implementations():
     for impl_dir in d:
         if not path.exists(impl_dir):
             logging.error('can not load implementations from {}. {} does not exist.'.format(impl_dir, impl_dir))
-            return
     load_files(d)
 
 

tests/test_utils.py

@@ -1,12 +1,17 @@
 from unittest import main, TestCase
+from getgauge.util import get_step_impl_dirs
 import os
 
 
 class UtilTests(TestCase):
 
+    def test_get_step_impl_gives_default_if_no_env_Set(self):
+        dirs = get_step_impl_dirs()
+        expected = ['step_impl']
+        self.assertEquals(dirs,expected)
+
     def test_get_step_impl_returns_array_of_impl_dirs(self):
-        os.environ["STEP_IMPL_DIR"] = "step_impl,step_impl1"
-        from getgauge.util import get_step_impl_dirs
+        os.environ["STEP_IMPL_DIR"] = "step_impl, step_impl1"
         dirs = get_step_impl_dirs()
         expected = ['step_impl','step_impl1']
         self.assertEquals(dirs,expected)