Skip to content

Commit cd6d292

Browse files
jpnurmialexsohn1126
authored andcommitted
ci: fix dirty-check for generated Cocoa bindings (#4600)
1 parent c665574 commit cd6d292

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

src/Sentry.Bindings.Cocoa/ApiDefinitions.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -416,9 +416,9 @@ interface SentryEnvelopeItemHeader : SentrySerializable
416416
[Export ("initWithType:length:filenname:contentType:")]
417417
NativeHandle Constructor (string type, nuint length, string filename, string contentType);
418418

419-
// -(instancetype _Nonnull)initWithType:(NSString * _Nonnull)type length:(NSUInteger)length contentType:(NSString * _Nonnull)contentType itemCount:(NSNumber * _Nonnull)itemCount;
419+
// -(instancetype _Nonnull)initWithType:(NSString * _Nonnull)type length:(NSUInteger)length contentType:(NSString * _Nullable)contentType itemCount:(NSNumber * _Nonnull)itemCount;
420420
[Export ("initWithType:length:contentType:itemCount:")]
421-
NativeHandle Constructor (string type, nuint length, string contentType, NSNumber itemCount);
421+
NativeHandle Constructor (string type, nuint length, [NullAllowed] string contentType, NSNumber itemCount);
422422

423423
// @property (readonly, copy, nonatomic) NSString * _Nonnull type;
424424
[Export ("type")]

src/Sentry.Bindings.Cocoa/Sentry.Bindings.Cocoa.csproj

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,15 +12,15 @@
1212
<SentryCocoaProperties>$([System.IO.File]::ReadAllText("$(MSBuildThisFileDirectory)../../modules/sentry-cocoa.properties"))</SentryCocoaProperties>
1313
<SentryCocoaVersion>$([System.Text.RegularExpressions.Regex]::Match($(SentryCocoaProperties), 'version\s*=\s*([^\s]+)').Groups[1].Value)</SentryCocoaVersion>
1414
<SentryCocoaFramework>$(SentryCocoaCache)Sentry-$(SentryCocoaVersion).xcframework</SentryCocoaFramework>
15-
<SentryCocoaBindingInputs>../../modules/sentry-cocoa.properties;../../scripts/generate-cocoa-bindings.ps1</SentryCocoaBindingInputs>
15+
<SentryCocoaBindingInputs>../../modules/sentry-cocoa.properties;../../scripts/generate-cocoa-bindings.ps1;$(SentryCocoaFrameworkHeaders)**/*.h</SentryCocoaBindingInputs>
1616
<!-- SentrySpan.g.cs: error CS0108: 'ISentrySpan.Serialize()' hides inherited member 'ISentrySerializable.Serialize()'. Use the new keyword if hiding was intended -->
1717
<NoWarn>$(NoWarn);CS0108</NoWarn>
1818
</PropertyGroup>
1919

2020
<!-- Override values for local Cocoa SDK builds -->
2121
<PropertyGroup Condition="Exists('$(SentryCocoaCache).git')">
2222
<SentryCocoaFramework>$(SentryCocoaCache)Carthage\Build-$(TargetPlatformIdentifier)\Sentry.xcframework</SentryCocoaFramework>
23-
<SentryCocoaBindingInputs>../../scripts/generate-cocoa-bindings.ps1;../../modules/sentry-cocoa/Carthage/.built-from-sha</SentryCocoaBindingInputs>
23+
<SentryCocoaBindingInputs>../../scripts/generate-cocoa-bindings.ps1;$(SentryCocoaCache)Carthage/.built-from-sha;$(SentryCocoaCache)Carthage/**/*.h</SentryCocoaBindingInputs>
2424
</PropertyGroup>
2525

2626
<!-- Build empty assemblies when not on macOS, to pass the solution build. -->

0 commit comments

Comments
 (0)