Skip to content

Commit 7f7971b

Browse files
committed
add TODO comments for sentry_value_as_uint64 + SIZE_MAX
1 parent bbfa7f3 commit 7f7971b

File tree

2 files changed

+6
-0
lines changed

2 files changed

+6
-0
lines changed

src/sentry_envelope.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -815,13 +815,17 @@ sentry_envelope_deserialize(const char *buf, size_t buf_len)
815815
}
816816
item->payload_len = (size_t)(payload_end - ptr);
817817
} else {
818+
// TODO: sentry_value_as_uint64
819+
// https://github.com/getsentry/sentry-native/pull/1301
818820
int payload_len = sentry_value_as_int32(length);
819821
if (payload_len < 0) {
820822
goto fail;
821823
}
822824
item->payload_len = (size_t)payload_len;
823825
}
824826
if (item->payload_len > 0) {
827+
// TODO: SIZE_MAX
828+
// https://github.com/getsentry/sentry-native/pull/1301
825829
if (ptr + item->payload_len > end
826830
|| item->payload_len > INT32_MAX - 1) {
827831
goto fail;

tests/unit/test_envelopes.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -671,6 +671,8 @@ SENTRY_TEST(deserialize_envelope_invalid)
671671
TEST_CHECK(!sentry_envelope_deserialize("{}\ninvalid\n", 11));
672672
TEST_CHECK(!sentry_envelope_deserialize("invalid", 7));
673673
TEST_CHECK(!sentry_envelope_deserialize("{}\n{\"length\":-1}\n", 17));
674+
// TODO: SIZE_MAX
675+
// https://github.com/getsentry/sentry-native/pull/1301
674676
char buf[128];
675677
snprintf(buf, sizeof(buf), "{}\n{\"length\":%d}\n", INT32_MAX);
676678
TEST_CHECK(!sentry_envelope_deserialize(buf, strlen(buf)));

0 commit comments

Comments
 (0)