🔧 chore: fix slack webhook commands endpoint typing (#89579)

Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>

Author: iamrajjoshi

pyproject.toml

@@ -133,7 +133,6 @@ module = [
     "sentry.integrations.pagerduty.actions.form",
     "sentry.integrations.pipeline",
     "sentry.integrations.slack.message_builder.notifications.issues",
-    "sentry.integrations.slack.webhooks.command",
     "sentry.integrations.slack.webhooks.event",
     "sentry.integrations.utils.sync",
     "sentry.integrations.vsts.integration",

src/sentry/integrations/slack/views/unlink_team.py

@@ -2,6 +2,7 @@
 
 from sentry.integrations.messaging.linkage import UnlinkTeamView
 from sentry.integrations.models.integration import Integration
+from sentry.integrations.services.integration import RpcIntegration
 from sentry.integrations.slack.views.linkage import SlackLinkageView
 from sentry.web.frontend.base import region_silo_view
 
@@ -15,8 +16,8 @@
 
 
 def build_team_unlinking_url(
-    integration: Integration,
-    organization_id: str,
+    integration: Integration | RpcIntegration,
+    organization_id: int,
     slack_id: str,
     channel_id: str,
     channel_name: str,

src/sentry/integrations/slack/webhooks/command.py

@@ -40,6 +40,8 @@
 INSUFFICIENT_ROLE_MESSAGE = (
     "You must be a Sentry organization admin/manager/owner or a team admin to link or unlink teams."
 )
+NO_USER_ID_MESSAGE = "Could not identify your Slack user ID. Please try again."
+NO_CHANNEL_ID_MESSAGE = "Could not identify the Slack channel ID. Please try again."
 
 
 def is_team_linked_to_channel(organization: Organization, slack_request: SlackDMRequest) -> bool:
@@ -97,6 +99,12 @@ def link_team(self, slack_request: SlackDMRequest) -> Response:
         if not has_valid_role:
             return self.reply(slack_request, INSUFFICIENT_ROLE_MESSAGE)
 
+        if not slack_request.user_id:
+            return self.reply(slack_request, NO_USER_ID_MESSAGE)
+
+        if not slack_request.channel_id:
+            return self.reply(slack_request, NO_CHANNEL_ID_MESSAGE)
+
         associate_url = build_team_linking_url(
             integration=integration,
             slack_id=slack_request.user_id,
@@ -131,6 +139,12 @@ def unlink_team(self, slack_request: SlackDMRequest) -> Response:
         if not is_valid_role(found) and not is_team_admin(found):
             return self.reply(slack_request, INSUFFICIENT_ROLE_MESSAGE)
 
+        if not slack_request.user_id:
+            return self.reply(slack_request, NO_USER_ID_MESSAGE)
+
+        if not slack_request.channel_id:
+            return self.reply(slack_request, NO_CHANNEL_ID_MESSAGE)
+
         associate_url = build_team_unlinking_url(
             integration=integration,
             organization_id=found.organization.id,