A sketch on how to edit workspaces on a high-level #10986
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Takeaways
Editorthat does all the heavy lifting and has access to therepoandworkspace, with the workspace containing metadata as well.replace()insertcan probably be implement based on the replace primitive, if there is an advantage.Technicalities
Graphas underlying data structure is useful as it has classification of commits, and as it can be traversed 'upwards'. This helps to select which commits are affected by edits.workspaceprojectionGraphand theworkspaceare their own data structures, editor-specific data has to be 'attached' using a separate mapping. Anything can be 'selected' bySegmentIndexandCommitIndex, maybe along with other markers as needed.This will need a lot of tests, even once the API is sketched out and found to be suitable.
What changed since the brainstorming session
editsare materialised directly, and the editor is consumed as part of producing these edits. That way it will be easier to implement, and user-input is expected to be provided as part of a repeated edit, on fresh data.