Skip to content

Commit f8a1735

Browse files
committed
Ruby: Get rid of competing module declaration
1 parent 7985701 commit f8a1735

File tree

3 files changed

+4
-7
lines changed

3 files changed

+4
-7
lines changed

ruby/ql/lib/codeql/ruby/security/UnsafeShellCommandConstructionCustomizations.qll

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -111,13 +111,10 @@ module UnsafeShellCommandConstruction {
111111
isUsedAsShellCommand(call, s) and
112112
(
113113
this = call.getReceiver() and
114-
not call.getReceiver().asExpr() instanceof Cfg::CfgNodes::ExprNodes::ArrayLiteralCfgNode
114+
not call.getReceiver().asExpr() instanceof CfgNodes::ExprNodes::ArrayLiteralCfgNode
115115
or
116116
this.asExpr() =
117-
call.getReceiver()
118-
.asExpr()
119-
.(Cfg::CfgNodes::ExprNodes::ArrayLiteralCfgNode)
120-
.getAnArgument()
117+
call.getReceiver().asExpr().(CfgNodes::ExprNodes::ArrayLiteralCfgNode).getAnArgument()
121118
)
122119
}
123120

ruby/ql/lib/codeql/ruby/security/WeakSensitiveDataHashingCustomizations.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ private module SensitiveDataSources {
6969
*/
7070
class SensitiveHashValueAccess extends SensitiveDataSource::Range instanceof SensitiveNode {
7171
SensitiveHashValueAccess() {
72-
this.asExpr() instanceof Cfg::CfgNodes::ExprNodes::ElementReferenceCfgNode
72+
this.asExpr() instanceof CfgNodes::ExprNodes::ElementReferenceCfgNode
7373
}
7474

7575
override SensitiveDataClassification getClassification() {

ruby/ql/lib/ruby.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,5 +3,5 @@
33
*/
44

55
import codeql.ruby.AST as Ast
6-
import codeql.ruby.CFG as Cfg
6+
import codeql.ruby.CFG
77
import codeql.ruby.DataFlow // already defines its own wrapper module

0 commit comments

Comments
 (0)