Skip to content

add github auth headers if there are GITHUB_TOKEN/GH_TOKEN set #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 20, 2025
Merged

add github auth headers if there are GITHUB_TOKEN/GH_TOKEN set #243

merged 2 commits into from
Sep 20, 2025

Conversation

@zryfish
Copy link

@zryfish zryfish commented Sep 14, 2025

  • Added _github_auth_headers() to read GH_TOKEN or GITHUB_TOKEN and return an Authorization header.
  • Applied the header to:
    - GitHub API call for latest release (client.get(...)).
    - Asset download request (client.stream(...)) to cover initial GitHub redirect.

@zryfish zryfish requested a review from localden as a code owner September 14, 2025 16:07
@localden
Copy link
Collaborator

Thanks for the contribution, @zryfish - is the scenario here that you want to run the CLI inside GitHub Actions, or generically on your development box?

@localden localden self-assigned this Sep 15, 2025
@zryfish
Copy link
Author

zryfish commented Sep 15, 2025 •
edited
Loading

Thanks for the contribution, @zryfish - is the scenario here that you want to run the CLI inside GitHub Actions, or generically on your development box?

I keep hitting the “rate limit exceeded” error on my laptop, even though I’m just on my home network. Still, this setup might come in handy when running in GitHub Actions or on a dev box.

GitHub API returned 403 for https://api.github.com/repos/github/spec-kit/releases/latest

@localden localden mentioned this pull request Sep 16, 2025
Closed
@localden
Copy link
Collaborator

Makes sense. @zryfish - let's also expose this as an argument to the CLI, like --github-token

@localden localden mentioned this pull request Sep 16, 2025
Open
@duccadhv1
Copy link

Makes sense. @zryfish - let's also expose this as an argument to the CLI, like --github-token

any update for cli argument?

@zryfish
Copy link
Author

zryfish commented Sep 17, 2025

Makes sense. @zryfish - let's also expose this as an argument to the CLI, like --github-token

any update for cli argument?

Yeah, I've added the cli argument --github-token. @localden Please take a look.

@reesechou2014
Copy link

The --github-token command has not been accepted yet.
GitHub API returned 403 for https://api.github.com/repos/github/spec-kit/releases/latest

@Saco93
Copy link

Saco93 commented Sep 19, 2025

Makes sense. @zryfish - let's also expose this as an argument to the CLI, like --github-token

any update for cli argument?

Yeah, I've added the cli argument --github-token. @localden Please take a look.

How about integrate gh auth token into it, for simplicity?

@localden localden merged commit 2825bb1 into github:main Sep 20, 2025
@localden
Copy link
Collaborator

Merged, thank you for the contribution @zryfish!

jellydn pushed a commit to jellydn/spec-kit that referenced this pull request Sep 30, 2025
@localden
Merge pull request github#243 from zryfish/dev/add_authentication_whe…
fa48769 
…n_download_template

add github auth headers if there are GITHUB_TOKEN/GH_TOKEN set
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@localden localden localden approved these changes

Assignees

@localden localden

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zryfish @localden @duccadhv1 @reesechou2014 @Saco93