Skip to content

Commit 1ab715e

Browse files
committed
refactor: remote fixme - permanent fix now
Signed-off-by: Adam Setch <[email protected]>
1 parent 261a85f commit 1ab715e

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

src/renderer/utils/helpers.ts

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -106,9 +106,11 @@ export async function generateGitHubWebUrl(
106106
): Promise<Link> {
107107
const url = new URL(notification.repository.html_url);
108108

109-
// FIXME see #1583
110-
// Upstream GitHub API has started returning subject urls for Discussion notification types,
111-
// however these URLs are broken. Temporarily downgrading to use discussion lookup process.
109+
/**
110+
* Discussions - override generic response values for subject and comment urls,
111+
* as we will fetch more specific html urls ourselves below
112+
* See issue #1583:
113+
*/
112114
if (notification.subject.type === 'Discussion') {
113115
notification.subject.url = null;
114116
notification.subject.latest_comment_url = null;

0 commit comments

Comments
 (0)