We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
There was an error while loading. Please reload this page.
1 parent 261a85f commit 1ab715eCopy full SHA for 1ab715e
src/renderer/utils/helpers.ts
@@ -106,9 +106,11 @@ export async function generateGitHubWebUrl(
106
): Promise<Link> {
107
const url = new URL(notification.repository.html_url);
108
109
- // FIXME see #1583
110
- // Upstream GitHub API has started returning subject urls for Discussion notification types,
111
- // however these URLs are broken. Temporarily downgrading to use discussion lookup process.
+ /**
+ * Discussions - override generic response values for subject and comment urls,
+ * as we will fetch more specific html urls ourselves below
112
+ * See issue #1583:
113
+ */
114
if (notification.subject.type === 'Discussion') {
115
notification.subject.url = null;
116
notification.subject.latest_comment_url = null;
0 commit comments