fix: clear global error state on fetch (#1443)

* fix: clear global error state on fetch

Signed-off-by: Adam Setch <[email protected]>

* fix: clear global error state on fetch

Signed-off-by: Adam Setch <[email protected]>

---------

Signed-off-by: Adam Setch <[email protected]>

Author: setchy

src/hooks/useNotifications.ts

@@ -60,6 +60,7 @@ export const useNotifications = (): NotificationsState => {
   const fetchNotifications = useCallback(
     async (state: GitifyState) => {
       setStatus('loading');
+      setGlobalError(null);
 
       const fetchedNotifications = await getAllNotifications(state);
 

src/routes/Notifications.tsx

@@ -4,10 +4,12 @@ import { AllRead } from '../components/AllRead';
 import { Oops } from '../components/Oops';
 import { AppContext } from '../context/App';
 import { getAccountUUID } from '../utils/auth/utils';
+import { Errors } from '../utils/constants';
 import { getNotificationCount } from '../utils/notifications';
 
 export const NotificationsRoute: FC = () => {
-  const { notifications, globalError, settings } = useContext(AppContext);
+  const { notifications, status, globalError, settings } =
+    useContext(AppContext);
 
   const hasMultipleAccounts = useMemo(
     () => notifications.length > 1,
@@ -24,8 +26,8 @@ export const NotificationsRoute: FC = () => {
     [notifications],
   );
 
-  if (globalError) {
-    return <Oops error={globalError} />;
+  if (status === 'error') {
+    return <Oops error={globalError ?? Errors.UNKNOWN} />;
   }
 
   if (!hasNotifications && hasNoAccountErrors) {