Skip to content

Commit dce646f

Browse files
authored
Merge pull request #265 from gluestack/feat/typings-spinner
feat: typings in spinner fixed
2 parents 2f53e9e + 8c29fcf commit dce646f

File tree

5 files changed

+11
-15
lines changed

5 files changed

+11
-15
lines changed

example/storybook/src/components/Feedback/Spinner/Spinner.stories.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ const SpinnerMeta: ComponentMeta<typeof Spinner> = {
77
argTypes: {
88
size: {
99
control: 'select',
10-
options: ['xs', 'small', 'md', 'large', 'xl'],
10+
options: ['xs', 'sm', 'md', 'lg', 'xl'],
1111
description: 'The size of the button.',
1212
table: {
1313
defaultValue: { summary: 'md' },

example/storybook/src/components/Feedback/Spinner/Spinner.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import { Spinner } from '../../../ui-components';
55
export const SpinnerStory = ({ ...props }) => {
66
return (
77
<Wrapper>
8-
<Spinner color="$primary500" {...props} size="small" />
8+
<Spinner color="$primary500" {...props} />
99
</Wrapper>
1010
);
1111
};
Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,2 @@
1-
import { createSpinner } from '@gluestack-ui/spinner';
2-
import { Root } from './styled-components';
3-
4-
export const Spinner = createSpinner({
5-
Root,
6-
}) as any;
1+
import { Spinner } from './styled-components';
2+
export { Spinner };
Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1,3 @@
1-
export { default as Root } from './Root';
1+
import Root from './Root';
2+
import { createSpinner } from '@gluestack-ui/spinner';
3+
export const Spinner = createSpinner({ Root });

packages/spinner/src/Spinner.tsx

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,10 @@
11
import React, { forwardRef } from 'react';
2-
3-
export function Spinner<StyledSpinnerProps>(
4-
StyledSpinner: React.ComponentType<StyledSpinnerProps>
5-
) {
6-
return forwardRef(({ ...props }: StyledSpinnerProps, ref: any) => {
2+
import type { ActivityIndicatorProps } from 'react-native';
3+
export function Spinner<T>(StyledSpinner: React.ComponentType<T>) {
4+
return forwardRef(({ ...props }: T & ActivityIndicatorProps, ref: any) => {
75
return (
86
<StyledSpinner
9-
{...(props as StyledSpinnerProps)}
7+
{...props}
108
ref={ref}
119
accessible
1210
accessibilityLabel="loading"

0 commit comments

Comments
 (0)