pkg/proc: add an event for spawned processes

Author: firelizzard18

pkg/proc/target_group.go

@@ -117,6 +117,9 @@ func (grp *TargetGroup) addTarget(p ProcessInternal, pid int, currentThread Thre
 	}
 	t, err := grp.newTarget(p, pid, currentThread, path, cmdline)
 	if err != nil {
+		// Notify listeners that a child process was spawned even though we
+		// can't debug it - listeners may care about non-Go processes.
+		grp.notifyProcessSpawned(pid, currentThread.ThreadID(), cmdline)
 		return nil, err
 	}
 	t.StopReason = stopReason
@@ -145,9 +148,29 @@ func (grp *TargetGroup) addTarget(p ProcessInternal, pid int, currentThread Thre
 		}
 	}
 	grp.targets = append(grp.targets, t)
+
+	// Notify listeners that a child process was spawned. We do this after the
+	// new target has been set up.
+	grp.notifyProcessSpawned(pid, currentThread.ThreadID(), cmdline)
 	return t, nil
 }
 
+func (grp *TargetGroup) notifyProcessSpawned(pid, threadID int, cmdline string) {
+	fn := grp.Selected.BinInfo().eventsFn
+	if fn == nil {
+		return
+	}
+
+	fn(&Event{
+		Kind: EventProcessSpawned,
+		ProcessSpawnedEventDetails: &ProcessSpawnedEventDetails{
+			PID:      pid,
+			ThreadID: threadID,
+			Cmdline:  cmdline,
+		},
+	})
+}
+
 // Targets returns a slice of all targets in the group, including the
 // ones that are no longer valid.
 func (grp *TargetGroup) Targets() []*Target {
@@ -576,6 +599,7 @@ type Event struct {
 	Kind EventKind
 	*BinaryInfoDownloadEventDetails
 	*BreakpointMaterializedEventDetails
+	*ProcessSpawnedEventDetails
 }
 
 type EventKind uint8
@@ -585,6 +609,7 @@ const (
 	EventStopped
 	EventBinaryInfoDownload
 	EventBreakpointMaterialized
+	EventProcessSpawned
 )
 
 // BinaryInfoDownloadEventDetails describes the details of a BinaryInfoDownloadEvent
@@ -596,3 +621,10 @@ type BinaryInfoDownloadEventDetails struct {
 type BreakpointMaterializedEventDetails struct {
 	Breakpoint *LogicalBreakpoint
 }
+
+// ProcessSpawnedEventDetails describes the details of a ProcessSpawnedEvent
+type ProcessSpawnedEventDetails struct {
+	PID      int
+	ThreadID int
+	Cmdline  string
+}

pkg/terminal/terminal.go

@@ -148,6 +148,8 @@ func New(client service.Client, conf *config.Config) *Term {
 				}
 
 				fmt.Fprintf(t.stdout, "Breakpoint %d materialized at %s:%d%s\n", bp.ID, file, bp.Line, extra)
+			case api.EventProcessSpawned:
+				fmt.Fprintf(t.stdout, "Spawned new process '%s' (%d)\n", event.Cmdline, event.ProcessSpawnedEventDetails.PID)
 			}
 		})
 	}

service/api/conversions.go

@@ -479,5 +479,13 @@ func ConvertEvent(event *proc.Event) *Event {
 		}
 	}
 
+	if event.ProcessSpawnedEventDetails != nil {
+		r.ProcessSpawnedEventDetails = &ProcessSpawnedEventDetails{
+			PID:      event.ProcessSpawnedEventDetails.PID,
+			ThreadID: event.ProcessSpawnedEventDetails.ThreadID,
+			Cmdline:  event.ProcessSpawnedEventDetails.Cmdline,
+		}
+	}
+
 	return r
 }

service/api/types.go

@@ -694,6 +694,7 @@ type Event struct {
 	Kind EventKind
 	*BinaryInfoDownloadEventDetails
 	*BreakpointMaterializedEventDetails
+	*ProcessSpawnedEventDetails
 }
 
 type EventKind uint8
@@ -703,6 +704,7 @@ const (
 	EventStopped
 	EventBinaryInfoDownload
 	EventBreakpointMaterialized
+	EventProcessSpawned
 )
 
 // BinaryInfoDownloadEventDetails describes the details of a BinaryInfoDownloadEvent
@@ -714,3 +716,10 @@ type BinaryInfoDownloadEventDetails struct {
 type BreakpointMaterializedEventDetails struct {
 	Breakpoint *Breakpoint
 }
+
+// ProcessSpawnedEventDetails describes the details of a ProcessSpawnedEvent
+type ProcessSpawnedEventDetails struct {
+	PID      int
+	ThreadID int
+	Cmdline  string
+}

service/dap/server.go

@@ -4103,6 +4103,12 @@ func (s *Session) convertDebuggerEvent(event *proc.Event) {
 			},
 		})
 	}
+	s.send(&dap.ProcessEvent{
+		Event: *newEvent("process"),
+		Body: dap.ProcessEventBody{
+			
+		},
+	})
 }
 
 type logMessage struct {