all: drop old +build foo stanza, use //go:build

sbinet · sbinet · commit 6c359638bc8c · 2022-03-22T15:56:28.000+01:00
Fixes #798.
diff --git a/ci/build-cxx-root.go b/ci/build-cxx-root.go
@@ -3,7 +3,6 @@
 // license that can be found in the LICENSE file.
 
 //go:build ignore
-// +build ignore
 
 // Command to build a given ROOT version from sources.
 package main
diff --git a/ci/install-cxx-root.go b/ci/install-cxx-root.go
@@ -3,7 +3,6 @@
 // license that can be found in the LICENSE file.
 
 //go:build ignore
-// +build ignore
 
 // Command to install a given (binary) ROOT version.
 package main
diff --git a/ci/mk-release.go b/ci/mk-release.go
@@ -3,7 +3,6 @@
 // license that can be found in the LICENSE file.
 
 //go:build ignore
-// +build ignore
 
 package main
 
diff --git a/ci/run-tests.go b/ci/run-tests.go
@@ -3,7 +3,6 @@
 // license that can be found in the LICENSE file.
 
 //go:build ignore
-// +build ignore
 
 package main
 
diff --git a/ci/update-godoc.go b/ci/update-godoc.go
@@ -3,7 +3,6 @@
 // license that can be found in the LICENSE file.
 
 //go:build ignore
-// +build ignore
 
 package main
 
diff --git a/fit/run.go b/fit/run.go
@@ -3,7 +3,6 @@
 // license that can be found in the LICENSE file.
 
 //go:build ignore
-// +build ignore
 
 package main
 
diff --git a/groot/cmd/root-gen-streamer/main_test.go b/groot/cmd/root-gen-streamer/main_test.go
@@ -145,7 +145,8 @@ key[000]: data;1 "" (go_hep_org::x::hep::groot::internal::rdatatest::T1) => &{he
 				t.Fatalf("could not recompile package with streamer data:\n%v\nerr: %v", out.String(), err)
 			}
 
-			err = os.WriteFile("testdata/run.go", []byte(fmt.Sprintf(`// +build ignore
+			err = os.WriteFile("testdata/run.go", []byte(fmt.Sprintf(`//go:build ignore
+
 package main
 
 import (
diff --git a/groot/cmd/root-gen-type/gen-data.go b/groot/cmd/root-gen-type/gen-data.go
@@ -3,7 +3,6 @@
 // license that can be found in the LICENSE file.
 
 //go:build ignore
-// +build ignore
 
 package main
 
diff --git a/groot/gen.rboot.go b/groot/gen.rboot.go
@@ -3,7 +3,6 @@
 // license that can be found in the LICENSE file.
 
 //go:build ignore
-// +build ignore
 
 // gen.rboot generates rdict streamers from the C++/ROOT ones.
 // gen.rboot generates ROOT class versions from the C++/ROOT streamers.
diff --git a/groot/gen.rbytes.go b/groot/gen.rbytes.go
@@ -3,7 +3,6 @@
 // license that can be found in the LICENSE file.
 
 //go:build ignore
-// +build ignore
 
 package main
 
diff --git a/groot/gen.rcont.go b/groot/gen.rcont.go
@@ -3,7 +3,6 @@
 // license that can be found in the LICENSE file.
 
 //go:build ignore
-// +build ignore
 
 package main
 
diff --git a/groot/gen.rhist.go b/groot/gen.rhist.go
@@ -3,7 +3,6 @@
 // license that can be found in the LICENSE file.
 
 //go:build ignore
-// +build ignore
 
 package main
 
diff --git a/groot/gen.rtree.go b/groot/gen.rtree.go
@@ -3,7 +3,6 @@
 // license that can be found in the LICENSE file.
 
 //go:build ignore
-// +build ignore
 
 package main
 
diff --git a/groot/internal/list-groot-sinfos.go b/groot/internal/list-groot-sinfos.go
@@ -3,7 +3,6 @@
 // license that can be found in the LICENSE file.
 
 //go:build ignore
-// +build ignore
 
 // list-groot-sinfos lists all the known StreamerInfos known to groot.
 package main
diff --git a/groot/internal/list-groot-types.go b/groot/internal/list-groot-types.go
@@ -3,7 +3,6 @@
 // license that can be found in the LICENSE file.
 
 //go:build ignore
-// +build ignore
 
 // list-groot-types lists all the groot types registered with the rtypes factory.
 package main
diff --git a/groot/internal/rcompress/notcompressible_test.go b/groot/internal/rcompress/notcompressible_test.go
@@ -3,7 +3,6 @@
 // license that can be found in the LICENSE file.
 
 //go:build !race
-// +build !race
 
 package rcompress
 
diff --git a/groot/internal/rcompress/rcompress_test.go b/groot/internal/rcompress/rcompress_test.go
@@ -3,7 +3,6 @@
 // license that can be found in the LICENSE file.
 
 //go:build !race
-// +build !race
 
 package rcompress_test
 
diff --git a/groot/riofs/gendata/gen-bitset-tree.go b/groot/riofs/gendata/gen-bitset-tree.go
@@ -3,7 +3,6 @@
 // license that can be found in the LICENSE file.
 
 //go:build ignore
-// +build ignore
 
 package main
 
diff --git a/groot/riofs/gendata/gen-dir.go b/groot/riofs/gendata/gen-dir.go
@@ -3,7 +3,6 @@
 // license that can be found in the LICENSE file.
 
 //go:build ignore
-// +build ignore
 
 package main
 
diff --git a/groot/riofs/gendata/gen-evnt-tree.go b/groot/riofs/gendata/gen-evnt-tree.go
@@ -3,7 +3,6 @@
 // license that can be found in the LICENSE file.
 
 //go:build ignore
-// +build ignore
 
 package main
 
diff --git a/groot/riofs/gendata/gen-flat-tree.go b/groot/riofs/gendata/gen-flat-tree.go
@@ -3,7 +3,6 @@
 // license that can be found in the LICENSE file.
 
 //go:build ignore
-// +build ignore
 
 package main
 
diff --git a/groot/riofs/gendata/gen-join-trees.go b/groot/riofs/gendata/gen-join-trees.go
@@ -3,7 +3,6 @@
 // license that can be found in the LICENSE file.
 
 //go:build ignore
-// +build ignore
 
 package main
 
diff --git a/groot/riofs/gendata/gen-map-tree.go b/groot/riofs/gendata/gen-map-tree.go
@@ -3,7 +3,6 @@
 // license that can be found in the LICENSE file.
 
 //go:build ignore
-// +build ignore
 
 package main
 
diff --git a/groot/riofs/gendata/gen-multi-leaves-tree.go b/groot/riofs/gendata/gen-multi-leaves-tree.go
@@ -3,7 +3,6 @@
 // license that can be found in the LICENSE file.
 
 //go:build ignore
-// +build ignore
 
 package main
 
diff --git a/groot/riofs/gendata/gen-ndim-slice.go b/groot/riofs/gendata/gen-ndim-slice.go
@@ -3,7 +3,6 @@
 // license that can be found in the LICENSE file.
 
 //go:build ignore
-// +build ignore
 
 package main
 
diff --git a/groot/riofs/gendata/gen-ndim.go b/groot/riofs/gendata/gen-ndim.go
@@ -3,7 +3,6 @@
 // license that can be found in the LICENSE file.
 
 //go:build ignore
-// +build ignore
 
 package main
 
diff --git a/groot/riofs/gendata/gen-small-evnt-tree.go b/groot/riofs/gendata/gen-small-evnt-tree.go
@@ -3,7 +3,6 @@
 // license that can be found in the LICENSE file.
 
 //go:build ignore
-// +build ignore
 
 package main
 
diff --git a/groot/riofs/gendata/gen-std-containers.go b/groot/riofs/gendata/gen-std-containers.go
@@ -3,7 +3,6 @@
 // license that can be found in the LICENSE file.
 
 //go:build ignore
-// +build ignore
 
 package main
 
diff --git a/groot/riofs/gendata/gen-tconflvl.go b/groot/riofs/gendata/gen-tconflvl.go
@@ -3,7 +3,6 @@
 // license that can be found in the LICENSE file.
 
 //go:build ignore
-// +build ignore
 
 package main
 
diff --git a/groot/riofs/gendata/gen-tdatime.go b/groot/riofs/gendata/gen-tdatime.go
@@ -3,7 +3,6 @@
 // license that can be found in the LICENSE file.
 
 //go:build ignore
-// +build ignore
 
 package main
 
diff --git a/groot/riofs/gendata/gen-tformula.go b/groot/riofs/gendata/gen-tformula.go
@@ -3,7 +3,6 @@
 // license that can be found in the LICENSE file.
 
 //go:build ignore
-// +build ignore
 
 package main
 
diff --git a/groot/riofs/gendata/gen-tgme.go b/groot/riofs/gendata/gen-tgme.go
@@ -3,7 +3,6 @@
 // license that can be found in the LICENSE file.
 
 //go:build ignore
-// +build ignore
 
 package main
 
diff --git a/groot/riofs/gendata/gen-tlv-tree.go b/groot/riofs/gendata/gen-tlv-tree.go
@@ -3,7 +3,6 @@
 // license that can be found in the LICENSE file.
 
 //go:build ignore
-// +build ignore
 
 package main
 
diff --git a/groot/riofs/gendata/gen-tntuple.go b/groot/riofs/gendata/gen-tntuple.go
@@ -3,7 +3,6 @@
 // license that can be found in the LICENSE file.
 
 //go:build ignore
-// +build ignore
 
 package main
 
diff --git a/groot/riofs/gendata/gen-tntupled.go b/groot/riofs/gendata/gen-tntupled.go
@@ -3,7 +3,6 @@
 // license that can be found in the LICENSE file.
 
 //go:build ignore
-// +build ignore
 
 package main
 
diff --git a/groot/riofs/gendata/gen-tprofile.go b/groot/riofs/gendata/gen-tprofile.go
@@ -3,7 +3,6 @@
 // license that can be found in the LICENSE file.
 
 //go:build ignore
-// +build ignore
 
 package main
 
diff --git a/groot/rtree/rfunc/gen-rfuncs.go b/groot/rtree/rfunc/gen-rfuncs.go
@@ -3,7 +3,6 @@
 // license that can be found in the LICENSE file.
 
 //go:build ignore
-// +build ignore
 
 package main
 
diff --git a/hbook/rootcnv/testdata/gen-2d-data.go b/hbook/rootcnv/testdata/gen-2d-data.go
@@ -3,7 +3,6 @@
 // license that can be found in the LICENSE file.
 
 //go:build ignore
-// +build ignore
 
 package main
 
diff --git a/hbook/rootcnv/testdata/make-hbook.go b/hbook/rootcnv/testdata/make-hbook.go
@@ -3,7 +3,6 @@
 // license that can be found in the LICENSE file.
 
 //go:build ignore
-// +build ignore
 
 package main
 
diff --git a/heppdt/gen-tabledata.go b/heppdt/gen-tabledata.go
@@ -3,7 +3,6 @@
 // license that can be found in the LICENSE file.
 
 //go:build ignore
-// +build ignore
 
 // gen-tabledata generates tabledata.go
 package main
diff --git a/hplot/cmd/iplot/main.go b/hplot/cmd/iplot/main.go
@@ -3,7 +3,6 @@
 // license that can be found in the LICENSE file.
 
 //go:build !cross_compile
-// +build !cross_compile
 
 package main
 
diff --git a/hplot/hplot_gen.go b/hplot/hplot_gen.go
@@ -3,7 +3,6 @@
 // license that can be found in the LICENSE file.
 
 //go:build tools
-// +build tools
 
 package hplot
 
diff --git a/pawgo/app.go b/pawgo/app.go
@@ -3,7 +3,6 @@
 // license that can be found in the LICENSE file.
 
 //go:build !cross_compile
-// +build !cross_compile
 
 package main
 
diff --git a/pawgo/app_xcomp.go b/pawgo/app_xcomp.go
@@ -3,7 +3,6 @@
 // license that can be found in the LICENSE file.
 
 //go:build cross_compile
-// +build cross_compile
 
 package main
 
diff --git a/pawgo/gen.hsimple.rio.go b/pawgo/gen.hsimple.rio.go
@@ -3,7 +3,6 @@
 // license that can be found in the LICENSE file.
 
 //go:build ignore
-// +build ignore
 
 package main
 
diff --git a/pawgo/wmgr.go b/pawgo/wmgr.go
@@ -3,7 +3,6 @@
 // license that can be found in the LICENSE file.
 
 //go:build !cross_compile
-// +build !cross_compile
 
 package main
 
diff --git a/pawgo/wmgr_xcomp.go b/pawgo/wmgr_xcomp.go
@@ -3,7 +3,6 @@
 // license that can be found in the LICENSE file.
 
 //go:build cross_compile
-// +build cross_compile
 
 package main
 
diff --git a/rio/testdata/gen-runhdr.go b/rio/testdata/gen-runhdr.go
@@ -3,7 +3,6 @@
 // license that can be found in the LICENSE file.
 
 //go:build ignore
-// +build ignore
 
 package main
 
diff --git a/sio/testdata/gen-runhdr.go b/sio/testdata/gen-runhdr.go
@@ -3,7 +3,6 @@
 // license that can be found in the LICENSE file.
 
 //go:build ignore
-// +build ignore
 
 package main
 
diff --git a/version.go b/version.go
diff --git a/version_example_test.go b/version_example_test.go
diff --git a/version_test.go b/version_test.go
diff --git a/xrootd/bind_test.go b/xrootd/bind_test.go
diff --git a/xrootd/go_server_test.go b/xrootd/go_server_test.go
diff --git a/xrootd/xrdproto/auth/krb5/krb5_unix.go b/xrootd/xrdproto/auth/krb5/krb5_unix.go
diff --git a/xrootd/xrdproto/auth/krb5/krb5_windows.go b/xrootd/xrdproto/auth/krb5/krb5_windows.go
diff --git a/xrootd/xrdproto/auth/unix/lookupgid_unix.go b/xrootd/xrdproto/auth/unix/lookupgid_unix.go
diff --git a/xrootd/xrdproto/auth/unix/lookupgid_windows.go b/xrootd/xrdproto/auth/unix/lookupgid_windows.go
diff --git a/xrootd/xrdproto/gen-marshal.go b/xrootd/xrdproto/gen-marshal.go

Original file line number	Diff line number	Diff line change
`@@ -145,7 +145,8 @@ key[000]: data;1 "" (go_hep_org::x::hep::groot::internal::rdatatest::T1) => &{he`
`145`	`145`	`t.Fatalf("could not recompile package with streamer data:\n%v\nerr: %v", out.String(), err)`
`146`	`146`	`}`
`147`	`147`
`148`		- err = os.WriteFile("testdata/run.go", []byte(fmt.Sprintf(`// +build ignore
	`148`	+ err = os.WriteFile("testdata/run.go", []byte(fmt.Sprintf(`//go:build ignore
	`149`	`+`
`149`	`150`	`package main`
`150`	`151`
`151`	`152`	`import (`