Fix handling of TypedArray polyfill methods in RemoveUnusedCode.

PiperOrigin-RevId: 826578479

Author: trevorade

src/com/google/javascript/jscomp/RemoveUnusedCode.java

@@ -87,31 +87,6 @@ class RemoveUnusedCode implements CompilerPass {
   private static final ImmutableSet<String> IMPLICITLY_USED_PROPERTIES =
       ImmutableSet.of("length", "toString", "valueOf", "constructor", "prototype");
 
-  /**
-   * Supported TypedArray subclasses.
-   *
-   * <p>Keep in sync with TYPED_ARRAY_CLASSES in js/build_polyfill_table.js.
-   */
-  // LINT.IfChange(typed_array_classes)
-  private static final ImmutableSet<String> TYPED_ARRAY_CLASSES =
-      ImmutableSet.of(
-          "Int8Array",
-          "Uint8Array",
-          "Uint8ClampedArray",
-          "Int16Array",
-          "Uint16Array",
-          "Int32Array",
-          "Uint32Array",
-          "Float32Array",
-          "Float64Array",
-          "BigInt64Array",
-          "BigUint64Array");
-
-  // LINT.ThenChange(
-  // //depot/google3/third_party/java_src/jscomp/java/com/google/javascript/jscomp/js/build_polyfill_table.js:typed_array_classes,
-  // //depot/google3/third_party/java_src/jscomp/java/com/google/javascript/jscomp/js/util/polyfill.js:typed_array_classes
-  // )
-
   private final AbstractCompiler compiler;
   private final AstAnalyzer astAnalyzer;
 
@@ -688,26 +663,13 @@ private void traverseCall(Node callNode, Scope scope) {
       // TODO(bradfordcsmith): Should also handle Object.create() and Object.defineProperty().
       traverseObjectDefinePropertiesCall(callNode, scope);
     } else if (removeUnusedPolyfills && isJscompPolyfill(callee)) {
-      boolean isPolyfillTypedArrayMethod =
-          callee.isName()
-              ? callee.getString().equals("$jscomp$polyfillTypedArrayMethod")
-              : callee.isGetProp() && callee.getString().equals("polyfillTypedArrayMethod");
-
       Node firstArg = callee.getNext();
-      String polyfillOrMethodName = firstArg.getString();
-
-      if (isPolyfillTypedArrayMethod) {
-        String methodName = polyfillOrMethodName;
-        for (String className : TYPED_ARRAY_CLASSES) {
-          String polyfillName = className + ".prototype." + methodName;
-          PolyfillInfo info = createPolyfillInfo(callNode, scope, polyfillName);
-          polyfills.put(info.key, info);
-        }
-      } else {
-        String polyfillName = polyfillOrMethodName;
-        PolyfillInfo info = createPolyfillInfo(callNode, scope, polyfillName);
-        polyfills.put(info.key, info);
+      String polyfillName = firstArg.getString();
+      if (callee.getString().endsWith("polyfillTypedArrayMethod")) {
+        polyfillName = "TypedArray.prototype." + polyfillName;
       }
+      PolyfillInfo info = createPolyfillInfo(callNode, scope, polyfillName);
+      polyfills.put(info.key, info);
       // Only traverse the callee (to mark it as used).  The arguments may be traversed later.
       traverseNode(callNode.getFirstChild(), scope);
     } else if (NodeUtil.isGoogWeakUsageCall(callNode)
@@ -2305,11 +2267,7 @@ private class Polyfill extends Removable {
 
     @Override
     public void removeInternal(AbstractCompiler compiler) {
-      // When usages of $jscomp.polyfillTypedArrayMethod are removed, it results in multiple
-      // attempts to delete the same polyfill function due to the various TypedArray subclasses.
-      if (!alreadyRemoved(polyfillNode)) {
-        NodeUtil.deleteNode(polyfillNode, compiler);
-      }
+      NodeUtil.deleteNode(polyfillNode, compiler);
     }
 
     @Override

src/com/google/javascript/jscomp/js/build_polyfill_table.js

@@ -51,7 +51,6 @@ const TYPED_ARRAY_CLASSES = [
   'BigUint64Array',
 ];
 // LINT.ThenChange(
-// //depot/google3/third_party/java_src/jscomp/java/com/google/javascript/jscomp/RemoveUnusedCode.java:typed_array_classes,
 // //depot/google3/third_party/java_src/jscomp/java/com/google/javascript/jscomp/js/util/polyfill.js:typed_array_classes
 // )
 

src/com/google/javascript/jscomp/js/util/polyfill.js

@@ -120,7 +120,6 @@ $jscomp.TYPED_ARRAY_CLASSES = (
         classes.push('BigUint64');
       }
       // LINT.ThenChange(
-      // //depot/google3/third_party/java_src/jscomp/java/com/google/javascript/jscomp/RemoveUnusedCode.java:typed_array_classes,
       // //depot/google3/third_party/java_src/jscomp/java/com/google/javascript/jscomp/js/build_polyfill_table.js:typed_array_classes
       // )
       return classes;