Secret agent man (#2348)

* accept desktop user agent for redirect

* mundane detail

Author: mikehelmick

pkg/controller/redirect/helpers.go

@@ -27,7 +27,8 @@ func isAndroid(userAgent string) bool {
 
 // isIOS determines if a User-Agent is an iOS EN device.
 func isIOS(userAgent string) bool {
-	return strings.Contains(strings.ToLower(userAgent), "iphone")
+	lAgent := strings.ToLower(userAgent)
+	return strings.Contains(lAgent, "iphone") || strings.Contains(lAgent, "macintosh")
 }
 
 // decideRedirect selects where to redirect based on several signals.

pkg/controller/redirect/helpers_test.go

@@ -229,6 +229,13 @@ func TestAgentDetection(t *testing.T) {
 			// For ENX purposes exclude iPad as it's unsupported.
 			ios: false,
 		},
+		{
+			name:      "osx_desktop",
+			userAgent: "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_9_3) AppleWebKit/537.75.14 (KHTML, like Gecko) Version/7.0.3 Safari/7046A194A",
+			android:   false,
+			// edge case, if a user has their browser in desktop mode, it sends a mac user agent
+			ios: true,
+		},
 	}
 
 	for _, tc := range cases {