Skip to content

Commit 5a32754

Browse files
konstantin-s-bogomgvisor-bot
authored andcommitted
Rework netfilter tests in preparation for running them on Buildkite.
The main goal of this rework is to make the netfilter tests better to work with on native Linux. The main change to this end is adding NetfilterBoundSocket, which helped debug what was going on with NetlinkNetfilterBatchRequestAckOrError on certain kernels. Prior to this, running the test natively on older kernels would simply block forever. Destroying test-created tables as cleanup actions has been removed in favour of simply creating uniquely-named tables. This is preferable in case the destroy command itself fails (as it does on older kernels), and we can guarantee that tables won't get reused between tests, which causes problems. ErrNewBaseChainWithUnsupportedFamilyChainTypePair has been removed because it is incorrect regarding native Linux behaviour; support for it needs to be added in gVisor but that's outside the scope of this CL. socket_netlink_netfilter_test was tested on Linux 6.8 (cgroupsv2 agents on buildkite). PiperOrigin-RevId: 823722006
1 parent f611d7f commit 5a32754

File tree

5 files changed

+476
-507
lines changed

5 files changed

+476
-507
lines changed

test/syscalls/linux/BUILD

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3729,7 +3729,9 @@ cc_library(
37293729
":socket_netlink_util",
37303730
"//test/util:file_descriptor",
37313731
"//test/util:posix_error",
3732+
"//test/util:test_util",
37323733
"@com_google_absl//absl/log",
3734+
"@com_google_absl//absl/strings:string_view",
37333735
],
37343736
)
37353737

0 commit comments

Comments
 (0)