-
Notifications
You must be signed in to change notification settings - Fork 165
chore(python): Add support for Python 3.14 #1593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @chalmerlowe, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces support for Python 3.14 across the project's development environment. The change primarily involves updating the automated configuration generation process to recognize and include Python 3.14 in the list of compatible Python versions, ensuring that testing and build processes can leverage the new interpreter version. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request aims to add support for Python 3.14. The current change in owlbot.py is incorrect because it attempts to replace a string that doesn't exist in noxfile.py. I've provided a suggestion to correctly update the UNIT_TEST_PYTHON_VERSIONS list. To complete the support for Python 3.14, you will also need to update nox.options.sessions and potentially other Python version lists in noxfile.py.
|
This is blocked on Python 3.14 support in |
This PR adds support for Python 3.14 to the library.
Key changes include:
noxfile.pyto include 3.14 sessions.CONTRIBUTING.rstto list Python 3.14 as a supported version and refreshing otherversion-related information.
owlbot.pyexcludes.