Skip to content

Commit 53a9ca2

Browse files
committed
fix typos
1 parent 03fd94b commit 53a9ca2

File tree

13 files changed

+135
-131
lines changed

13 files changed

+135
-131
lines changed

CHANGELOG.md

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,13 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
66
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
77

88
## [Unreleased]
9+
## [0.11.0] - 2025-5-25
10+
### Changed
11+
- Referencing Rhino.Scripting 0.11.0
12+
### Added
13+
- build for .NET 7 too
14+
### Fixed
15+
- typos in documentation
916

1017
## [0.10.2] - 2025-03-25
1118
### Fixed
@@ -24,7 +31,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
2431
## [0.8.2] - 2025-02-24
2532
### Changed
2633
- Referencing Rhino.Scripting 0.8.0
27-
- rename Rhino.Scripting.FSharp -> Rhino.Scripting.FSharp (capital S)
34+
- rename Rhino.Scripting.Fsharp -> Rhino.Scripting.FSharp (capital S)
2835

2936
## [0.8.1] - 2024-10-06
3037
### Changed
@@ -40,7 +47,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
4047
- First public release
4148
- Referencing Rhino.Scripting 0.5.0
4249

43-
[Unreleased]: https://github.com/goswinr/Rhino.Scripting.FSharp/compare/0.10.2...HEAD
50+
[Unreleased]: https://github.com/goswinr/Rhino.Scripting.FSharp/compare/0.11.0...HEAD
51+
[0.11.0]: https://github.com/goswinr/Rhino.Scripting.FSharp/compare/0.10.2...0.11.0
4452
[0.10.2]: https://github.com/goswinr/Rhino.Scripting.FSharp/compare/0.10.1...0.10.2
4553
[0.10.1]: https://github.com/goswinr/Rhino.Scripting.FSharp/compare/0.10.0...0.10.1
4654
[0.10.0]: https://github.com/goswinr/Rhino.Scripting.FSharp/compare/0.8.2...0.10.0

Docs/docs.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
the files Readme.md is copied from the root to this docs folder as index.md via .github/workflow/docs.yml
1+
the file README.md is copied from the root to this docs folder as index.md via .github/workflow/docs.yml

Src/RhPoints.fs

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ open Rhino.Scripting
1313
module RhPoints =
1414

1515

16-
/// returns the closest point index form a Point list to a given Point
16+
/// returns the closest point index from a Point list to a given Point
1717
let closestPointIdx (pt:Point3d) (pts:ResizeArray<Point3d>) : int =
1818
if pts.Count = 0 then RhinoScriptingFSharpException.Raise "RhPoints.closestPoint empty List of Points: pts"
1919
let mutable mi = -1
@@ -26,7 +26,7 @@ module RhPoints =
2626
mi <- i
2727
mi
2828

29-
/// returns the closest point form a Point list to a given Point
29+
/// returns the closest point from a Point list to a given Point
3030
let closestPoint (pt:Point3d) (pts:ResizeArray<Point3d>) : Point3d=
3131
pts.[closestPointIdx pt pts]
3232

@@ -55,7 +55,7 @@ module RhPoints =
5555
Point3d.distance xs.[i] ys.[j]
5656

5757
/// find the index of the point that has the biggest distance to any point from the other set
58-
/// basically the mos lonely point in 'findPointFrom' list with respect to 'checkAgainst' list
58+
/// basically the most lonely point in 'findPointFrom' list with respect to 'checkAgainst' list
5959
/// returns findPointFromIdx * checkAgainstIdx
6060
let mostDistantPointIdx (findPointFrom:ResizeArray<Point3d>) (checkAgainst:ResizeArray<Point3d>) : int*int=
6161
if findPointFrom.Count = 0 then RhinoScriptingFSharpException.Raise "RhPoints.mostDistantPoint empty List of Points: findPointFrom"
@@ -84,7 +84,7 @@ module RhPoints =
8484
findPointFrom.[i]
8585

8686

87-
/// Culls points if they are to close to previous or next item
87+
/// Culls points if they are too close to previous or next item
8888
/// Last and first points stay the same
8989
let cullDuplicatePointsInSeq (tolerance) (pts:ResizeArray<Point3d>) =
9090
if pts.Count = 0 then RhinoScriptingFSharpException.Raise "RhPoints.cullDuplicatePointsInSeq empty List of Points: pts"
@@ -110,7 +110,7 @@ module RhPoints =
110110

111111

112112
let internal minIndexBy (projection : 'T -> 'Key) (xs: ResizeArray<'T>) : int =
113-
if xs.Count = 0 then RhinoScriptingFSharpException.Raise "RhPoints.ResizeArr.minIndexBy: Failed on empty ." // noReflection for Fable. <%O>" typeof<'T>
113+
if xs.Count = 0 then RhinoScriptingFSharpException.Raise "RhPoints.ResizeArr.minIndexBy: Failed on empty." // noReflection for Fable. <%O>" typeof<'T>
114114
let mutable f = projection xs.[0]
115115
let mutable mf = f
116116
let mutable ii = 0
@@ -121,7 +121,7 @@ module RhPoints =
121121
mf <- f
122122
ii
123123
let internal maxIndexBy (projection : 'T -> 'Key) (xs: ResizeArray<'T>) : int =
124-
if xs.Count = 0 then RhinoScriptingFSharpException.Raise "RhPoints.ResizeArr.maxIndBy: Failed on empty ResizeArray." // noReflection for Fable. <%O>" typeof<'T>
124+
if xs.Count = 0 then RhinoScriptingFSharpException.Raise "RhPoints.ResizeArr.maxIndexBy: Failed on empty ResizeArray." // noReflection for Fable. <%O>" typeof<'T>
125125
let mutable f = projection xs.[0]
126126
let mutable mf = f
127127
let mutable ii = 0
@@ -148,8 +148,8 @@ module RhPoints =
148148
res
149149

150150

151-
/// Similar to Join Polylines this tries to find continuous sequences of points.
152-
/// 'tolGap' is the maximum allowable gap between the start and the endpoint of to segments.
151+
/// Similar to Join Polylines, this tries to find continuous sequences of points.
152+
/// 'tolGap' is the maximum allowable gap between the start and the endpoint of two segments.
153153
/// Search starts from the segment with the most points.
154154
/// Both start and end point of each point list is checked for adjacency
155155
let findContinuousPoints (tolGap:float) (ptss: ResizeArray<ResizeArray<Point3d>>) =

Src/RhTopology.fs

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -9,15 +9,15 @@ open Rhino.Scripting.RhinoScriptingUtils
99
[<RequireQualifiedAccess>]
1010
module RhTopology =
1111

12-
// The same function exist on FsEX.ResizeArray module too but with extra error checking.
12+
// The same function exists on FsEX.ResizeArray module too but with extra error checking.
1313
// Swap the values of two given indices in ResizeArray
1414
let inline private swap i j (xs:ResizeArray<'T>) :unit =
1515
if i<>j then
1616
let ti = xs.[i]
1717
xs.[i] <- xs.[j]
1818
xs.[j] <- ti
1919

20-
// The same function exist on FsEX.ResizeArray module too but with extra error checking.
20+
// The same function exists on FsEX.ResizeArray module too but with extra error checking.
2121
// Like ResizeArray.minIndexBy but starting to search only from a given index
2222
let inline private minIndexByFrom (compareBy: 'T -> 'U) fromIdx (xs:ResizeArray<'T>) : int =
2323
let mutable idx = fromIdx
@@ -30,24 +30,24 @@ module RhTopology =
3030
idx
3131

3232
/// Sorts elements in place to be in a circular structure.
33-
/// for each line end point it finds the next closest line start point.
33+
/// For each line end point it finds the next closest line start point.
3434
/// (Does not check other line end points that might be closer)
3535
/// Line is used as an abstraction to hold start and end of arbitrary object.
3636
let sortToLoop(getLine: 'T -> Line) (xs:ResizeArray<'T>) =
3737
for i = 0 to xs.Count - 2 do // only run till second last
3838
let thisLine = getLine xs.[i]
39-
// TODO could be optimized using a R-Tree for very large lists instead of minBy function
39+
// TODO could be optimized using an R-Tree for very large lists instead of minBy function
4040
let nextIdx = xs |> minIndexByFrom (fun c -> RhinoScriptSyntax.DistanceSquare ((getLine c).From , thisLine.To) ) (i+1)
4141
xs |> swap (i+1) nextIdx
4242

43-
/// Sorts elements in place to be in a circular structure.
43+
/// Sorts elements in place to be in a circular structure.
4444
/// For each line end it finds the next closest start point or end point.
4545
/// Line is used as an abstraction to hold start and end of arbitrary object.
46-
/// Reverses the input in place, where required via reverseInPlace function that takes the index of the element as parameter.
46+
/// Reverses the input in place, where required via reverseInPlace function that takes the index of the element as parameter.
4747
let sortToLoopWithReversing (getLine: 'T -> Line) (reverseInPlace: int -> 'T -> unit) (xs:ResizeArray<'T>) : unit =
4848
for i = 0 to xs.Count - 2 do // only run till second last
4949
let thisLine = getLine xs.[i]
50-
// TODO could be optimized using a R-Tree for very large lists instead of minBy function
50+
// TODO could be optimized using an R-Tree for very large lists instead of minBy function
5151
let nextIdxSt = xs |> minIndexByFrom (fun c -> RhinoScriptSyntax.DistanceSquare ((getLine c).From , thisLine.To) ) (i+1)
5252
let nextIdxEn = xs |> minIndexByFrom (fun c -> RhinoScriptSyntax.DistanceSquare ((getLine c).To , thisLine.To) ) (i+1)
5353
// check if closest endpoint is closer than closest start-point

Src/Rhino.Scripting/Brep.fs

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -83,13 +83,13 @@ module AutoOpenBrep =
8383
let cy = Cylinder(circ,length)
8484
Brep.CreateFromCylinder(cy, capBottom=true, capTop=true)
8585

86-
///<summary>Creates a Brep in the Shape of a Countersunk Screw Hole , 45 degrees slope
87-
/// a caped cone and a cylinder. one closed Polysurface </summary>
86+
///<summary>Creates a Brep in the shape of a Countersunk Screw Hole, 45 degrees slope.
87+
/// A capped cone and a cylinder. One closed Polysurface.</summary>
8888
///<param name="plane">(Plane) Origin is center of cone-base or head</param>
89-
///<param name="outerDiameter">(float) diameter of cone base</param>
89+
///<param name="outerDiameter">(float) Diameter of cone base</param>
9090
///<param name="innerDiameter">(float) Diameter of cylinder</param>
91-
///<param name="length">(float) total length of the screw brep</param>
92-
///<returns>(Brep) Brep Geometry.</returns>
91+
///<param name="length">(float) Total length of the screw brep</param>
92+
///<returns>(Brep) Brep geometry.</returns>
9393
static member CreateCounterSunkScrewVolume ( plane:Plane, outerDiameter, innerDiameter, length) : Brep =
9494
let r = outerDiameter*0.5
9595
let mutable plco = Plane(plane)
@@ -110,12 +110,12 @@ module AutoOpenBrep =
110110
if brep.SolidOrientation = BrepSolidOrientation.Inward then
111111
brep.Flip()
112112
brep
113-
///<summary>Transforms a planar 2D curve in XY plane to the given plane and then extrudes it with CapPlanarHoles, with option extensions at both ends.</summary>
113+
///<summary>Transforms a planar 2D curve in XY plane to the given plane and then extrudes it with CapPlanarHoles, with optional extensions at both ends.</summary>
114114
///<param name="curveToExtrudeInWorldXY">(Curve) A curve in world XY plane</param>
115115
///<param name="plane">(Plane) A plane with any orientation</param>
116-
///<param name="height">(float) the hight to extrude along the Z axis of plane</param>
117-
///<param name="extraHeightPerSide">(float) Optional, Default Value: <c>0.0</c> , extra extension of the extrusion on both sides </param>
118-
///<returns>(Brep) Brep Geometry.</returns>
116+
///<param name="height">(float) The height to extrude along the Z axis of plane</param>
117+
///<param name="extraHeightPerSide">(float) Optional, Default Value: <c>0.0</c>, extra extension of the extrusion on both sides</param>
118+
///<returns>(Brep) Brep geometry.</returns>
119119
static member CreateExtrusionAtPlane(curveToExtrudeInWorldXY:Curve, plane:Plane, height, [<OPT;DEF(0.0)>]extraHeightPerSide:float) : Brep =
120120
let mutable pl = Plane(plane)
121121
if extraHeightPerSide <> 0.0 then
@@ -134,12 +134,12 @@ module AutoOpenBrep =
134134
///<summary>Subtracts trimmer from brep (= BooleanDifference),
135135
/// so that a single brep is returned,
136136
/// draws objects and zooms on them if an error occurs.</summary>
137-
///<param name="trimmer">(Brep)the volume to cut out</param>
137+
///<param name="trimmer">(Brep) The volume to cut out</param>
138138
///<param name="keep">(Brep) The volume to keep</param>
139-
///<param name="subtractionLocations">(int) Optional, The amount of locations where the brep is expected to be cut
139+
///<param name="subtractionLocations">(int) Optional, The number of locations where the brep is expected to be cut
140140
/// This is an optional safety check that makes it twice as slow.
141-
/// It ensures that the count of breps from Brep.CreateBooleanIntersection is equal to subtractionLocations </param>
142-
///<returns>(Brep) Brep Geometry.</returns>
141+
/// It ensures that the count of breps from Brep.CreateBooleanIntersection is equal to subtractionLocations</param>
142+
///<returns>(Brep) Brep geometry.</returns>
143143
static member SubtractBrep (keep:Brep,trimmer:Brep,[<OPT;DEF(0)>]subtractionLocations:int) :Brep =
144144
let draw s b = RhinoScriptSyntax.Ot.AddBrep(b)|> RhinoScriptSyntax.setLayer s
145145

@@ -192,9 +192,9 @@ module AutoOpenBrep =
192192
brep
193193

194194
///<summary> Calls Mesh.CreateFromBrep, and Mesh.HealNakedEdges() to try to ensure Mesh is closed if input is closed.</summary>
195-
///<param name="brep">(Brep)the Polysurface to extract Mesh from.</param>
196-
///<param name="meshingParameters">(MeshingParameters) Optional, The Meshing parameters , if omitted the current Meshing parameters are used. </param>
197-
///<returns>((Mesh Result) Ok Mesh or Error Mesh if input brep is closed but output Mesh not. Fails if no Meshes can be extracted.</returns>
195+
///<param name="brep">(Brep) The Polysurface to extract Mesh from.</param>
196+
///<param name="meshingParameters">(MeshingParameters) Optional, The meshing parameters, if omitted the current meshing parameters are used.</param>
197+
///<returns>(Result&lt;Mesh,Mesh&gt;) Ok Mesh or Error Mesh if input brep is closed but output Mesh not. Fails if no meshes can be extracted.</returns>
198198
static member ExtractRenderMesh (brep:Brep,[<OPT;DEF(null:MeshingParameters)>]meshingParameters:MeshingParameters) :Result<Mesh,Mesh> =
199199
let meshing =
200200
if notNull meshingParameters then

0 commit comments

Comments
 (0)