Skip to content

Commit d9e16c0

Browse files
committed
Remove non-latest patch versions to limit testing overhead
1 parent 2db5756 commit d9e16c0

File tree

3 files changed

+5
-16
lines changed

3 files changed

+5
-16
lines changed

build.gradle

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -25,17 +25,8 @@ def supportedVersions = [
2525
"4.2.0-alpha04": ["6.5.1"],
2626
"4.1.0-beta03": ["6.5.1"],
2727
"4.0.1": ["6.1.1", "6.3", "6.4.1"],
28-
"4.0.0": ["6.1.1"],
2928
"3.6.4": ["5.6.4", "6.3", "6.4.1"],
30-
"3.6.3": ["5.6.4"],
31-
"3.6.2": ["5.6.4"],
32-
"3.6.1": ["5.6.4"],
33-
"3.6.0": ["5.6.4"],
34-
"3.5.4": ["5.4.1", "5.6.4", "6.3", "6.4.1"],
35-
"3.5.3": ["5.4.1"],
36-
"3.5.2": ["5.4.1"],
37-
"3.5.1": ["5.4.1"],
38-
"3.5.0": ["5.4.1"]
29+
"3.5.4": ["5.4.1", "5.6.4", "6.3", "6.4.1"]
3930
]
4031

4132
repositories {

src/main/groovy/org/gradle/android/AndroidCacheFixPlugin.groovy

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ class AndroidCacheFixPlugin implements Plugin<Project> {
6262
void apply(Project project) {
6363
if (!isSupportedAndroidVersion()) {
6464
if (isMaybeSupportedAndroidVersion()) {
65-
project.logger.warn("WARNING: Android plugin ${CURRENT_ANDROID_VERSION} has not been tested with this version of the Android cache fix plugin, although it may work. This is likely because it is newly released and we haven't had a chance to release a new version of Android cache fix that supports it. Proceed with caution. You can suppress this warning with with -D${IGNORE_VERSION_CHECK_PROPERTY}=true.")
65+
project.logger.warn("WARNING: Android plugin ${CURRENT_ANDROID_VERSION} has not been tested with this version of the Android cache fix plugin, although it may work. We test against only the latest patch release versions of Android Gradle plugin: ${SUPPORTED_ANDROID_VERSIONS.join(", ")}. If ${CURRENT_ANDROID_VERSION} is newly released, we may not have had a chance to release a version tested against it yet. Proceed with caution. You can suppress this warning with with -D${IGNORE_VERSION_CHECK_PROPERTY}=true.")
6666
} else {
6767
throw new RuntimeException("Android plugin ${CURRENT_ANDROID_VERSION} is not supported by Android cache fix plugin. Supported Android plugin versions: ${SUPPORTED_ANDROID_VERSIONS.join(", ")}. Override with -D${IGNORE_VERSION_CHECK_PROPERTY}=true.")
6868
}

src/test/groovy/org/gradle/android/PluginApplicationTest.groovy

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -27,20 +27,18 @@ class PluginApplicationTest extends AbstractTest {
2727

2828
}
2929

30-
// Temporarily ignored until we come up with a better way of testing this that doesn't introduce flakiness
31-
@Ignore
3230
def "warns when version is not supported but within range"() {
3331
def projectDir = temporaryFolder.newFolder()
3432
SimpleAndroidApp.builder(projectDir, cacheDir)
35-
.withAndroidVersion("3.6.3")
33+
.withAndroidVersion("3.6.1")
3634
.build()
3735
.writeProject()
3836

3937
expect:
4038
def result = withGradleVersion(Versions.latestGradleVersion().version)
4139
.withProjectDir(projectDir)
42-
.withArguments("tasks", "--stacktrace", "-D${Versions.OMIT_VERSION_PROPERTY}=3.6.3")
40+
.withArguments("tasks", "--stacktrace")
4341
.build()
44-
result.output =~ /WARNING: Android plugin ${quote("3.6.3")} has not been tested with this version of the Android cache fix plugin, although it may work. This is likely because it is newly released and we haven't had a chance to release a new version of Android cache fix that supports it. Proceed with caution. You can suppress this warning with with -Dorg.gradle.android.cache-fix.ignoreVersionCheck=true./
42+
result.output =~ /WARNING: Android plugin ${quote("3.6.1")} has not been tested with this version of the Android cache fix plugin, although it may work. We test against only the latest patch release versions of Android Gradle plugin: ${Versions.SUPPORTED_ANDROID_VERSIONS.join(", ")}. If 3.6.1 is newly released, we may not have had a chance to release a version tested against it yet. Proceed with caution. You can suppress this warning with with -Dorg.gradle.android.cache-fix.ignoreVersionCheck=true./
4543
}
4644
}

0 commit comments

Comments
 (0)