Merge pull request #121 from runningcode/no/task-config-avoidance

Avoid configuring JavaCompile tasks eagerly.

Author: runningcode

src/main/groovy/org/gradle/android/workarounds/CompilerArgsProcessor.groovy

@@ -40,7 +40,7 @@ class CompilerArgsProcessor {
         }
         applied = true
 
-        project.tasks.withType(JavaCompile) { JavaCompile task ->
+        project.tasks.withType(JavaCompile).configureEach { JavaCompile task ->
             project.gradle.taskGraph.beforeTask {
                 if (task == it) {
                     def processedArgs = processArgs(task.options.compilerArgs, task)

src/test/groovy/org/gradle/android/TaskAvoidanceTest.groovy

@@ -0,0 +1,35 @@
+package org.gradle.android
+
+import spock.lang.Unroll
+
+class TaskAvoidanceTest extends AbstractTest {
+    @Unroll
+    def "Source Tasks are avoided with #gradleVersion and Android plugin #androidVersion"() {
+        given:
+        SimpleAndroidApp.builder(temporaryFolder.root, cacheDir)
+                .withAndroidVersion(androidVersion)
+                .withKotlinDisabled()
+                .build()
+                .writeProject()
+
+        file('build.gradle') << """
+            allprojects {
+              tasks.withType(SourceTask).configureEach {
+                println "configuring \$it"
+              }
+            }
+        """
+
+        when:
+        def result = withGradleVersion(gradleVersion.version)
+                .withProjectDir(temporaryFolder.root)
+                .withArguments('help')
+                .build()
+
+        then:
+        !result.output.contains("configuring")
+
+        where:
+        [androidVersion, gradleVersion] << Versions.SUPPORTED_VERSIONS_MATRIX.entries().collect { [it.key, it.value] }
+    }
+}