You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Have any questions? Check out the contributing docs at https://gruntwork.notion.site/Gruntwork-Coding-Methodology-02fdcd6e4b004e818553684760bf691e,
80
80
or ask in this Pull Request and a Gruntwork core maintainer will be happy to help :)
81
-
Note: Remember to add '[WIP]' to the beginning of the title if this PR is still a work-in-progress.
81
+
Note: Remember to add '[WIP]' to the beginning of the title if this PR is still a work-in-progress. Remove it when it is ready for review!
82
82
-->
83
83
84
84
## Description
@@ -96,31 +96,26 @@ Note: Remember to add '[WIP]' to the beginning of the title if this PR is still
96
96
- Create a stub for documentation including bullet points for how to use the feature, code snippets (including from happy path tests), etc.
97
97
-->
98
98
99
-
<!-- Important: Did you make any backwards incompatible changes? If yes, then you must write a migration guide! -->
99
+
<!-- Important: Did you make any backward incompatible changes? If yes, then you must write a migration guide! -->
100
100
101
101
## TODOs
102
102
103
+
Please ensure all of these TODOs are completed before asking for a review.
104
+
103
105
- [ ] Ensure the branch is named correctly with the issue number. e.g: `feature/new-vpc-endpoints-955` or `bug/missing-count-param-434`.
104
106
- [ ] Update the docs.
105
-
- [ ] Keep the changes backwards compatible where possible.
107
+
- [ ] Keep the changes backward compatible where possible.
106
108
- [ ] Run the pre-commit checks successfully.
107
109
- [ ] Run the relevant tests successfully.
108
-
- [ ] Ensure any 3rd party code adheres with our license policy: https://www.notion.so/gruntwork/Gruntwork-licenses-and-open-source-usage-policy-f7dece1f780341c7b69c1763f22b1378
109
-
- [ ] _Maintainers Only._ If necessary, release a new version of this repo.
110
-
- [ ] _Maintainers Only._ If there were backwards incompatible changes, include a migration guide in the release notes.
111
-
- [ ] _Maintainers Only._ Add to the next version of the monthly newsletter (see https://www.notion.so/gruntwork/Monthly-Newsletter-9198cbe7f8914d4abce23dca7b435f43).
110
+
- [ ] Ensure any 3rd party code adheres with our [license policy](https://www.notion.so/gruntwork/Gruntwork-licenses-and-open-source-usage-policy-f7dece1f780341c7b69c1763f22b1378) or delete this line if its not applicable.
112
111
113
112
114
113
## Related Issues
115
114
116
115
<!--
117
-
Link to the issue that is fixed by this PR (if there is one)
116
+
Link to related issues, and issues fixed or partially addressed by this PR.
118
117
e.g. Fixes #1234
119
-
120
-
Link to an issue that is partially addressed by this PR (if there are any)
0 commit comments