Add Accomplishment model and API endpoints for Feature #48 #530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 tasks
fyliu
moved this to PR Needs review (automated column, do not place items here manually)
in P: PD: Project Board
dmartin4820
requested changes
Sep 8, 2025
There was a problem hiding this comment.
The only thing still missing that I can tell is a test for the new accomplishment model.
Attaching a link to the tutorial I normally follow as a checklist of things to do.
github-project-automation
bot
moved this from PR Needs review (automated column, do not place items here manually)
to PR changes requested
in P: PD: Project Board
dmartin4820
requested changes
Sep 16, 2025
drakeredwind01
force-pushed
the
Feature/48-drakeredwind01-accomplishment
branch
from
ab51173 to
1637d67
Compare
for more information, see https://pre-commit.ci
dmartin4820
requested changes
Oct 30, 2025
|
|
||
| .vscode | ||
| TODO.md | ||
| TODO.md |
There was a problem hiding this comment.
Why is TODO.md added? I don't see it in the repo
| @@ -1 +1,2 @@ | |||
| 0042_urlstatustype_projecturl_url_status_type | |||
| 0039_accomplishment | |||
There was a problem hiding this comment.
Does this run without error for you? I tried running your code but I get these errors shown below:
.
| uuid = models.UUIDField( | ||
| primary_key=True, default=uuid.uuid4, editable=False, unique=True | ||
| ) | ||
| created_at = models.DateTimeField("Created at", auto_now_add=True) |
There was a problem hiding this comment.
why did we remove these fields? these are used by many other models. This looks related to the snapshot that I took in the max_migration.txt comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #48
What changes did you make?
Why did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
N/A (No visual changes, backend implementation only)
Visuals after changes are applied
N/A (No visual changes, backend implementation only)
Files Modified/Added:
app/core/api/serializers.pyapp/core/api/views.pyapp/core/api/urls.pyapp/core/admin.pyapp/core/tests/test_api.pyapp/core/migrations/0039_accomplishment.pyReference: