WIP: quic: Add a BUG_ON to qc_send()

haproxyFred · haproxyFred · commit 353786e817d7 · 2024-11-18T17:32:17.000+01:00
This is to ensure qc_send() respects the &lt;max_dgrams&gt; limit passed
as parameter.
diff --git a/src/quic_tx.c b/src/quic_tx.c
@@ -880,6 +880,7 @@ int qc_send(struct quic_conn *qc, int old_data, struct list *send_list,
 		}
 
 		ret += prep_pkts;
+		BUG_ON(max_dgrams && ret > max_dgrams);
 		if (max_dgrams && ret == max_dgrams && !LIST_ISEMPTY(send_list)) {
 			TRACE_DEVEL("stopping for artificial pacing", QUIC_EV_CONN_TXPKT, qc);
 			break;

Original file line number	Diff line number	Diff line change
`@@ -880,6 +880,7 @@ int qc_send(struct quic_conn qc, int old_data, struct list send_list,`
`880`	`880`	`}`
`881`	`881`
`882`	`882`	`ret += prep_pkts;`
	`883`	`+ BUG_ON(max_dgrams && ret > max_dgrams);`
`883`	`884`	`if (max_dgrams && ret == max_dgrams && !LIST_ISEMPTY(send_list)) {`
`884`	`885`	`TRACE_DEVEL("stopping for artificial pacing", QUIC_EV_CONN_TXPKT, qc);`
`885`	`886`	`break;`