Skip to content

Commit 99497d2

Browse files
committed
BUG/MINOR: cfgparse-quic: fix warning for cc-aglo with 0 burst
Optional burst argument for quic-cc-algo is used to toggle pacing support on top of cubic. This is the case if it is positive. The default value is 0, which do not activate pacing. However, in this case, an incorrect warning is reported about the parameter being ignored. Fix this by removing the warning in this case. No need to backport.
1 parent ea17de0 commit 99497d2

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

src/cfgparse-quic.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -188,7 +188,11 @@ static int bind_parse_quic_cc_algo(char **args, int cur_arg, struct proxy *px,
188188
if (burst < 0)
189189
goto fail;
190190

191-
if (burst && cc_algo->type == QUIC_CC_ALGO_TP_CUBIC) {
191+
if (cc_algo->type != QUIC_CC_ALGO_TP_CUBIC) {
192+
ha_warning("'%s' : burst parameter ignored for '%s' congestion algorithm\n",
193+
args[cur_arg], algo);
194+
}
195+
else if (burst) {
192196
if (!experimental_directives_allowed) {
193197
memprintf(err, "'%s' : support for pacing is experimental, must be allowed via a global "
194198
"'expose-experimental-directives'\n", args[cur_arg]);
@@ -199,10 +203,6 @@ static int bind_parse_quic_cc_algo(char **args, int cur_arg, struct proxy *px,
199203
cc_algo->pacing_rate = quic_cc_default_pacing_rate;
200204
cc_algo->pacing_burst = quic_cc_default_pacing_burst;
201205
}
202-
else {
203-
ha_warning("'%s' : burst parameter ignored for '%s' congestion algorithm\n",
204-
args[cur_arg], algo);
205-
}
206206

207207
if (*end_opt == ')') {
208208
goto out;

0 commit comments

Comments
 (0)