Skip to content

Commit d840505

Browse files
committed
improve prompts
1 parent 0b117de commit d840505

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

lib/.claude/commands/implement-bidi-feature.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,3 +16,4 @@ In order to do that you will need to:
1616
* You will have to implement the code as close as possible to the original code, but adapted to .NET idioms and practices.
1717
* As part of the task you will need to generate a document explaining the changes you made, and how they relate to the original PR.
1818
* You need to run related tests to ensure everything is working as expected.
19+
* You will need to run the tests using the ENV variables BROWSER=FIREFOX and PROTOCOL=bidi

lib/CLAUDE.md

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -390,16 +390,17 @@ Test directory structure demonstrates comprehensive coverage:
390390
### Building and Running Tests
391391

392392
When running tests, always build first and then use the `--no-build` flag to avoid rebuilding during test execution. This provides faster and more reliable test runs:
393+
Always be explicit with the browser and protocol you want to test using ENV variables BROWSER=FIREFOX|CHROME and PROTOCOL=bidi|cdp
393394

394395
```bash
395396
# Build the test project first
396-
dotnet build PuppeteerSharp.Tests/PuppeteerSharp.Tests.csproj
397+
BROWSER=FIREFOX PROTOCOL=bidi dotnet build PuppeteerSharp.Tests/PuppeteerSharp.Tests.csproj
397398

398399
# Then run tests with --no-build flag
399-
dotnet test PuppeteerSharp.Tests/PuppeteerSharp.Tests.csproj --filter "FullyQualifiedName~TestName" --no-build -- NUnit.TestOutputXml=TestResults
400+
BROWSER=CHROME PROTOCOL=bidi dotnet test PuppeteerSharp.Tests/PuppeteerSharp.Tests.csproj --filter "FullyQualifiedName~TestName" --no-build -- NUnit.TestOutputXml=TestResults
400401

401402
# Can also chain them together
402-
dotnet build PuppeteerSharp.Tests/PuppeteerSharp.Tests.csproj && dotnet test PuppeteerSharp.Tests/PuppeteerSharp.Tests.csproj --filter "FullyQualifiedName~TestName" --no-build -- NUnit.TestOutputXml=TestResults
403+
BROWSER=CHROME PROTOCOL=cdp dotnet build PuppeteerSharp.Tests/PuppeteerSharp.Tests.csproj && dotnet test PuppeteerSharp.Tests/PuppeteerSharp.Tests.csproj --filter "FullyQualifiedName~TestName" --no-build -- NUnit.TestOutputXml=TestResults
403404
```
404405

405406
You can switch between CDP and Bidi by changing the PuppeteerTestAttribute.IsCdp property.

0 commit comments

Comments
 (0)