Skip to content

Conversation

@ffaf1
Copy link
Collaborator

@ffaf1 ffaf1 commented Nov 9, 2025

Nothing much to do:

  • I did not bump cabal-version as this is a minor release.
  • I verified cabal build --allow-newer -cQuickCheck==2.17.1.0 … works with the relevant targets.

  • Patches conform to the coding conventions.
  • Is this a PR that fixes CI? no If so, it will need to be backported to older cabal release branches (ask maintainers for directions).

Copy link
Collaborator

@ulysses4ever ulysses4ever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Terrific, thanks!

Copy link
Collaborator

@geekosaur geekosaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There have been coordinated changes between Cabal and cabal-install that require cabal-install to use the new Cabal, IIRC. (#11101, which is a critical bug fix) So the bound on Cabal needs to be bumped as well. This won't be seen in CI because the one in the project will always be used.

Copy link
Collaborator

@geekosaur geekosaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On second thought, that won't matter on master, but it needs to be done in the backport.

@ffaf1 ffaf1 added merge me Tell Mergify Bot to merge and removed attention: needs-review labels Nov 9, 2025
@mergify mergify bot added ready and waiting Mergify is waiting out the cooldown period merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days queued labels Nov 9, 2025
mergify bot added a commit that referenced this pull request Nov 11, 2025
@mergify mergify bot merged commit fbc055e into haskell:master Nov 11, 2025
390 of 393 checks passed
@mergify mergify bot removed the queued label Nov 11, 2025
@ffaf1 ffaf1 deleted the preflight-3.16 branch November 12, 2025 08:37
@ffaf1
Copy link
Collaborator Author

ffaf1 commented Nov 12, 2025

@mergify backport 3.12

@mergify
Copy link
Contributor

mergify bot commented Nov 12, 2025

backport 3.12

✅ Backports have been created

@ffaf1
Copy link
Collaborator Author

ffaf1 commented Nov 12, 2025

Backporting manually in #11280 for 3.16.

@ffaf1
Copy link
Collaborator Author

ffaf1 commented Nov 12, 2025

@mergify backport 3.14

@mergify
Copy link
Contributor

mergify bot commented Nov 12, 2025

backport 3.14

✅ Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

attention: needs-backport 3.14 merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge ready and waiting Mergify is waiting out the cooldown period release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants