Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?xml version="1.0" encoding="UTF-8"?>
<!--

Copyright (c) 2022, 2024 Oracle and/or its affiliates.
Copyright (c) 2022, 2025 Oracle and/or its affiliates.

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?xml version="1.0" encoding="UTF-8"?>
<!--

Copyright (c) 2023 Oracle and/or its affiliates.
Copyright (c) 2023, 2025 Oracle and/or its affiliates.

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
Expand All @@ -26,9 +26,10 @@
<list key="dependencies">
<map order="800">
<value key="groupId">io.opentelemetry</value>
<value key="artifactId">opentelemetry-exporter-jaeger</value>
<value key="artifactId">opentelemetry-exporter-otlp</value>
</map>
</list>
<value key="tracing.provider.otel">otlp</value>
</model>
</output>
</method>
Expand All @@ -41,6 +42,7 @@
<value key="artifactId">opentelemetry-exporter-zipkin</value>
</map>
</list>
<value key="tracing.provider.otel">${tracing.provider}</value>
</model>
</output>
</method>
Expand All @@ -65,7 +67,7 @@
<value template="mustache"><![CDATA[
#OpenTelemetry
otel.sdk.disabled=false
otel.traces.exporter={{tracing.provider}}
otel.traces.exporter={{tracing.provider.otel}}
otel.service.name=helidon-tracing-service]]></value>
</list>
<list key="module-requires">
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?xml version="1.0" encoding="UTF-8"?>
<!--

Copyright (c) 2023 Oracle and/or its affiliates.
Copyright (c) 2023, 2025 Oracle and/or its affiliates.

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -47,11 +47,13 @@ tracing:
</map>
<map if="${tracing.provider} == 'jaeger'">
<value key="groupId">io.helidon.tracing.providers</value>
<value key="artifactId">helidon-tracing-providers-jaeger</value>
<value key="artifactId">helidon-tracing-providers-opentelemetry</value>
<value key="tracing.provider.otel">otlp</value>
</map>
<map if="${tracing.provider} == 'zipkin'">
<value key="groupId">io.helidon.tracing.providers</value>
<value key="artifactId">helidon-tracing-providers-zipkin</value>
<value key="tracing.provider.otel">${tracing.provider}</value>
</map>
</list>
<list key="Main-routing-builder">
Expand Down
16 changes: 12 additions & 4 deletions dependencies/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -145,12 +145,15 @@
<version.lib.ojdbc.family>23</version.lib.ojdbc.family>
<version.lib.ojdbc>${version.lib.ojdbc.family}.9.0.25.07</version.lib.ojdbc>
<version.lib.ojdbc8>${version.lib.ojdbc}</version.lib.ojdbc8>
<!-- Force upgrade okio for dependency convergence: bring otel otlp exporter up to what langchain4j uses -->
<version.lib.okio>3.6.0</version.lib.okio>
<!-- Force upgrade okhttp3 for dependency convergence -->
<version.lib.okhttp3>4.12.0</version.lib.okhttp3>
<version.lib.opentelemetry.semconv>1.29.0-alpha</version.lib.opentelemetry.semconv>
<version.lib.opentelemetry-sdk-extension-autoconfigure>1.29.0</version.lib.opentelemetry-sdk-extension-autoconfigure>
<version.lib.opentelemetry.opentracing.shim>1.29.0</version.lib.opentelemetry.opentracing.shim>
<version.lib.opentelemetry>1.29.0</version.lib.opentelemetry>
<version.lib.opentelemetry-sdk-extension-autoconfigure>1.53.0</version.lib.opentelemetry-sdk-extension-autoconfigure>
<version.lib.opentelemetry.opentracing.shim>1.53.0</version.lib.opentelemetry.opentracing.shim>
<version.lib.opentelemetry>1.53.0</version.lib.opentelemetry>
<version.lib.opentelemetry.instrumentation.annotations>2.19.0</version.lib.opentelemetry.instrumentation.annotations>
<version.lib.opentracing>0.33.0</version.lib.opentracing>
<version.lib.opentracing.grpc>0.2.1</version.lib.opentracing.grpc>
<version.lib.opentracing.tracerresolver>0.1.8</version.lib.opentracing.tracerresolver>
Expand Down Expand Up @@ -273,7 +276,7 @@
<dependency>
<groupId>io.opentelemetry.instrumentation</groupId>
<artifactId>opentelemetry-instrumentation-annotations</artifactId>
<version>${version.lib.opentelemetry}</version>
<version>${version.lib.opentelemetry.instrumentation.annotations}</version>
</dependency>
<dependency>
<groupId>io.opentelemetry.instrumentation</groupId>
Expand Down Expand Up @@ -1247,6 +1250,11 @@
<artifactId>okhttp</artifactId>
<version>${version.lib.okhttp3}</version>
</dependency>
<dependency>
<groupId>com.squareup.okio</groupId>
<artifactId>okio</artifactId>
<version>${version.lib.okio}</version>
</dependency>
<!-- END OF Section 3: transitive dependencies we manage the version of for convergence/upgrade -->

<!-- Section 4: Testing -->
Expand Down
2 changes: 1 addition & 1 deletion microprofile/telemetry/src/main/java/module-info.java
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
requires jakarta.annotation;
requires jakarta.inject;
requires microprofile.config.api;
requires opentelemetry.instrumentation.annotations;
requires io.opentelemetry.instrumentation_annotations;
requires io.opentelemetry.semconv;

requires static io.helidon.common.features.api;
Expand Down
25 changes: 19 additions & 6 deletions tracing/providers/jaeger/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,24 @@
</dependency>
<dependency>
<groupId>io.opentelemetry</groupId>
<artifactId>opentelemetry-exporter-jaeger</artifactId>
<artifactId>opentelemetry-exporter-otlp</artifactId>
<exclusions>
<exclusion>
<groupId>io.opentelemetry</groupId>
<artifactId>opentelemetry-exporter-sender-okhttp</artifactId>
</exclusion>
</exclusions>
</dependency>
<dependency>
<groupId>io.opentelemetry</groupId>
<artifactId>opentelemetry-exporter-sender-grpc-managed-channel</artifactId>
<version>${version.lib.opentelemetry}</version>
<scope>runtime</scope>
</dependency>
<dependency>
<groupId>io.grpc</groupId>
<artifactId>grpc-okhttp</artifactId>
<scope>runtime</scope>
</dependency>
<dependency>
<groupId>io.helidon.tracing.providers</groupId>
Expand Down Expand Up @@ -97,11 +114,7 @@
<artifactId>opentelemetry-sdk-extension-autoconfigure</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>io.opentelemetry</groupId>
<artifactId>opentelemetry-exporter-otlp</artifactId>
<scope>test</scope>
</dependency>

<!-- -->

<dependency>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,8 @@
import io.opentelemetry.api.common.AttributesBuilder;
import io.opentelemetry.context.propagation.ContextPropagators;
import io.opentelemetry.context.propagation.TextMapPropagator;
import io.opentelemetry.exporter.jaeger.JaegerGrpcSpanExporter;
import io.opentelemetry.exporter.jaeger.JaegerGrpcSpanExporterBuilder;
import io.opentelemetry.exporter.otlp.trace.OtlpGrpcSpanExporter;
import io.opentelemetry.exporter.otlp.trace.OtlpGrpcSpanExporterBuilder;
import io.opentelemetry.extension.trace.propagation.B3Propagator;
import io.opentelemetry.extension.trace.propagation.JaegerPropagator;
import io.opentelemetry.sdk.OpenTelemetrySdk;
Expand Down Expand Up @@ -157,7 +157,7 @@ public class JaegerTracerBuilder implements TracerBuilder<JaegerTracerBuilder> {
static final boolean DEFAULT_ENABLED = true;
static final String DEFAULT_HTTP_HOST = "localhost";
static final int DEFAULT_SCHEDULE_DELAY = 5_000;
static final int DEFAULT_HTTP_PORT = 14250;
static final int DEFAULT_HTTP_PORT = 4317;
static final int DEFAULT_MAX_QUEUE_SIZE = 2048;
static final int DEFAULT_MAX_EXPORT_BATCH_SIZE = 512;

Expand Down Expand Up @@ -495,7 +495,7 @@ public Tracer build() {
"Configuration must at least contain the 'service' key ('tracing.service` in MP) with service name");
}

JaegerGrpcSpanExporterBuilder spanExporterBuilder = JaegerGrpcSpanExporter.builder()
OtlpGrpcSpanExporterBuilder spanExporterBuilder = OtlpGrpcSpanExporter.builder()
.setEndpoint(protocol + "://" + host + ":" + port + (path == null ? "" : path))
.setTimeout(exporterTimeout);

Expand Down
2 changes: 1 addition & 1 deletion tracing/providers/jaeger/src/main/java/module-info.java
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
requires io.helidon.common.configurable;
requires io.helidon.common.context;
requires io.helidon.tracing.providers.opentelemetry;
requires io.opentelemetry.exporter.jaeger;
requires io.opentelemetry.exporter.otlp;
requires io.opentelemetry.sdk.common;
requires io.opentelemetry.sdk.trace;
requires io.opentelemetry.sdk;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2019, 2024 Oracle and/or its affiliates.
* Copyright (c) 2019, 2025 Oracle and/or its affiliates.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -75,7 +75,7 @@ void testConfigDefaults() {
assertThat("Tags", jBuilder.tags(), is(Map.of()));
assertThat("Protocol", jBuilder.protocol(), is("http"));
assertThat("Host", jBuilder.host(), is("localhost"));
assertThat("Port", jBuilder.port(), is(14250));
assertThat("Port", jBuilder.port(), is(4317));
assertThat("Path", jBuilder.path(), nullValue());
assertThat("Enabled", jBuilder.isEnabled(), is(true));
assertThat("Sampler type", jBuilder.samplerType(), is(JaegerTracerBuilder.SamplerType.CONSTANT));
Expand Down
Loading