Add flex resize, focus mode, hard-coded limits for now (clone of #2704) #8546

sander777 · 2023-10-16T14:13:06Z

This feature had been implemented in #2704, but PR seams inactive. I really wanted this feature and just copy pasted code from original PR.

Fixes #1176

helix-view/src/tree.rs

the-mikedavis · 2023-10-21T09:08:19Z

If you're re-submitting someone else's code it's customary to credit them as a co-author in the commits: https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors

archseer · 2023-10-22T11:00:44Z

If it's as far as simply rebasing the original work I'd keep the commit authorship as is and either add a Co-authored-by or a separate commit with the fixes

sander777 · 2023-11-03T15:37:48Z

There was a problem with author's name on old commits. Now everything looks fine

mattkang · 2024-07-31T18:16:18Z

Is there anything I can do to help get this PR merged? Would be great to have this feature.

the-mikedavis · 2024-08-16T21:09:15Z

helix-term/src/keymap/default.rs

+        "A-w" => { "Alter Window"
+            "A-h"|"A-left" |"h"|"left" => shrink_buffer_width,
+            "A-l"|"A-right"|"l"|"right" => grow_buffer_width,
+            "A-j"|"A-down" |"j"|"down" => shrink_buffer_height,
+            "A-k"|"A-up"   |"k"|"up" => grow_buffer_height,
+            "A-f"|"f" => toggle_focus_window,
+        },


I wonder if we need the non-sticky version of this at all? I don't imagine that you would want to make a single edit to the sizes.

I'm also not sure about the keybinding. Instead I think this might fit better as a minor mode under C-w/<space>w specifically for resizing and move the f binding under C-w/<space>w instead

the-mikedavis · 2024-08-16T21:17:04Z

helix-view/src/editor.rs

+    pub fn resize_buffer(&mut self, resize_type: Resize, dimension: Dimension) {
+        self.tree.resize_buffer(resize_type, dimension);
+    }
+
+    pub fn toggle_focus_window(&mut self) {


there's some inconsistency here between "buffer" and "window". I would call both of these "view"s to match the internal wording

the-mikedavis · 2024-08-16T21:22:02Z

helix-term/src/commands.rs

+fn grow_buffer_width(cx: &mut Context) {
+    cx.editor.resize_buffer(Resize::Grow, Dimension::Width);
+}
+
+fn shrink_buffer_width(cx: &mut Context) {
+    cx.editor.resize_buffer(Resize::Shrink, Dimension::Width);
+}
+fn grow_buffer_height(cx: &mut Context) {
+    cx.editor.resize_buffer(Resize::Grow, Dimension::Height);
+}
+
+fn shrink_buffer_height(cx: &mut Context) {
+    cx.editor.resize_buffer(Resize::Shrink, Dimension::Height);
+}


This strikes me as not the right API for resizing. I would expect that commands would hardcode the amount/ratio or take the cx.count() into account to decide how much to resize. With this API it's hard to introduce resizing windows by mouse dragging the separator for example, and we can take the terminals cells into account to give an exact amount. I think @pascalkuthe has similar thoughts here if he'd like to weigh in

For an example of another pane resizing thing in the wild: in sway/i3 you can create a mode to resize like I have here: https://github.com/the-mikedavis/dotfiles/blob/51d85cb1f258300b6fc90427fe7c1069ff924a64/defaults/sway/default.nix#L255-L271

That's what I'm thinking for the sticky mode and the hardcoding of amounts to resize by

yeah I think using terminal cells/pixels as aboslute positions instead of these relative slots makes more sense to me

jakDev003 · 2024-08-19T21:46:03Z

This sure would be a great feature if we could just get that second reviewer so this can be merged that would be great! Please and thank you!

nik-rev · 2025-01-14T21:15:55Z

This sure would be a great feature if we could just get that second reviewer so this can be merged that would be great! Please and thank you!

It looks like the maintainers left some comments which weren't addressed

jchidley · 2025-01-31T16:22:49Z

I've just rediscovered the split feature in Helix and remembered why a fixed size limits it usefulness. Looking forward to having this PR merged.

ref: helix-editor/helix#1176 ref: helix-editor/helix#2704 ref: helix-editor/helix#8546 Co-authored-by: Sander Cyber <[email protected]>

YPares · 2025-04-21T18:34:43Z

Hi! Any chance to get this merged?

Ochiruko · 2025-05-14T05:50:06Z

Super nice QoL feature to have. Can't wait until this gets merged!

m4rch3n1ng · 2025-10-08T21:29:42Z

since this pr seems to be stale and the author hasn't had activity on github since a while and there are open review comments, that aren't addressed, i have taken this pr and revived it in #14559, (hopefully correctly) addressing the outstanding reviews comments.

sander777 changed the title ~~Add flex resize, focus mode, hard-coded limits for now (clone of https://github.com/helix-editor/helix/pull/2704)~~ Add flex resize, focus mode, hard-coded limits for now (clone of [#2704](https://github.com/helix-editor/helix/pull/2704)) Oct 16, 2023

sander777 changed the title ~~Add flex resize, focus mode, hard-coded limits for now (clone of [#2704](https://github.com/helix-editor/helix/pull/2704))~~ Add flex resize, focus mode, hard-coded limits for now (clone of #2704) Oct 16, 2023

archseer reviewed Oct 17, 2023

View reviewed changes

helix-view/src/tree.rs Outdated Show resolved Hide resolved

kirawi added A-helix-term Area: Helix term improvements S-waiting-on-review Status: Awaiting review from a maintainer. labels Oct 17, 2023

sander777 force-pushed the resize-windows branch 5 times, most recently from 1238d49 to 3b59425 Compare October 21, 2023 19:07

sander777 force-pushed the resize-windows branch 2 times, most recently from 277910a to 165070b Compare October 23, 2023 16:05

the-mikedavis mentioned this pull request Oct 25, 2023

Add flex resize, focus mode, hard-coded limits for now #2704

Closed

Termina94 and others added 6 commits October 25, 2023 16:27

Add flex resize, focus mode, hard-coded limits for now

64311f7

refactor buffer resize to single function

d8fbff3

rename focus to expand

e4c9054

refactor editor resize functions

6891014

add sticky mode for 'alter window' pane

5aaaf13

renaming;some key-mapping fixes;refactoring

978c1a1

sander777 force-pushed the resize-windows branch 3 times, most recently from 2bed1e6 to 982c008 Compare November 3, 2023 15:21

Merge Resize windows correct author

1d79ba9

sander777 force-pushed the resize-windows branch from 982c008 to 1d79ba9 Compare November 3, 2023 15:31

Termina94 mentioned this pull request Dec 11, 2023

Resize windows #1176

Open

This comment was marked as spam.

Sign in to view

sander777 requested a review from archseer December 27, 2023 15:13

sander777 added 2 commits April 4, 2024 23:28

Merge branch 'master' into resize-windows

5a830c7

fix lints errors

7c54c63

sander777 force-pushed the resize-windows branch from 332cc8e to 7c54c63 Compare April 4, 2024 21:01

Merge branch 'master' into resize-windows

036e5c3

sander777 force-pushed the resize-windows branch from afbb861 to 036e5c3 Compare May 17, 2024 21:05

Merge branch 'master' into resize-windows

7bb4ed2

sander777 force-pushed the resize-windows branch from 0dde7a6 to 7bb4ed2 Compare August 1, 2024 18:21

archseer requested a review from the-mikedavis August 8, 2024 23:30

archseer approved these changes Aug 8, 2024

View reviewed changes

archseer added this to the next milestone Aug 9, 2024

the-mikedavis reviewed Aug 16, 2024

View reviewed changes

the-mikedavis added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from a maintainer. labels Aug 16, 2024

omentic pushed a commit to omentic/helix-ext that referenced this pull request Feb 22, 2025

Support for resizing windows

3009289

ref: helix-editor/helix#1176 ref: helix-editor/helix#2704 ref: helix-editor/helix#8546 Co-authored-by: Sander Cyber <[email protected]>

This comment was marked as spam.

Sign in to view

m4rch3n1ng mentioned this pull request Oct 8, 2025

add window resizing (second revive of #2704) #14559

Open

Uh oh!

Add flex resize, focus mode, hard-coded limits for now (clone of #2704) #8546

Are you sure you want to change the base?

Add flex resize, focus mode, hard-coded limits for now (clone of #2704) #8546

Conversation

sander777 commented Oct 16, 2023 • edited by the-mikedavis Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

the-mikedavis commented Oct 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

archseer commented Oct 22, 2023

Uh oh!

sander777 commented Nov 3, 2023

Uh oh!

This comment was marked as spam.

mattkang commented Jul 31, 2024

Uh oh!

the-mikedavis Aug 16, 2024

Choose a reason for hiding this comment

Uh oh!

the-mikedavis Aug 16, 2024

Choose a reason for hiding this comment

Uh oh!

the-mikedavis Aug 16, 2024

Choose a reason for hiding this comment

Uh oh!

the-mikedavis Aug 16, 2024

Choose a reason for hiding this comment

Uh oh!

pascalkuthe Aug 16, 2024

Choose a reason for hiding this comment

Uh oh!

jakDev003 commented Aug 19, 2024

Uh oh!

nik-rev commented Jan 14, 2025

Uh oh!

jchidley commented Jan 31, 2025

Uh oh!

This comment was marked as spam.

YPares commented Apr 21, 2025

Uh oh!

Ochiruko commented May 14, 2025

Uh oh!

m4rch3n1ng commented Oct 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

15 participants

sander777 commented Oct 16, 2023 •

edited by the-mikedavis

Loading

the-mikedavis commented Oct 21, 2023 •

edited

Loading