You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: CONTRIBUTING.md
+4-6Lines changed: 4 additions & 6 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -7,7 +7,7 @@ our [HiveMQ Community Repo](https://github.com/hivemq/hivemq-community).
7
7
## Prerequisites
8
8
9
9
We recommend to develop your changes by using [IntelliJ IDEA](https://www.jetbrains.com/idea/).
10
-
Therefore, the following guide will focus on creating your changes by using IntelliJ.
10
+
Therefore, the following guide will focus on creating your changes using IntelliJ.
11
11
12
12
Furthermore, the following is needed to make your development efforts as smoothly as possible:
13
13
- A Java 11 JDK (we recommend [temurin](https://adoptium.net/de/temurin/releases/?version=11)) => [Set the JDK in IntelliJ](https://www.jetbrains.com/help/idea/sdk.html)
@@ -53,7 +53,7 @@ Furthermore, the following is needed to make your development efforts as smoothl
53
53
- Implement your changes under `src/main/java`
54
54
- You can use the existing code as a guide
55
55
- The project uses Nullability annotations to avoid NullPointerExceptions: `@NotNull`, `@Nullable`.
56
-
Every non-primitive parameter/return type/field should be annotated with one of them.
56
+
Every non-primitive parameter, return type and field should be annotated with one of them.
57
57
58
58
## 4. Write tests
59
59
@@ -67,10 +67,7 @@ Furthermore, the following is needed to make your development efforts as smoothl
67
67
68
68
## 5. Build and test
69
69
70
-
- Before you build mqtt-cli, make sure that
71
-
- a Docker daemon is running
72
-
- you have installed the native image tooling by using `./gradlew installNativeImageTooling`
73
-
- To build mqtt-cli use `./gradlew build`
70
+
- See [Building from source](https://hivemq.github.io/mqtt-cli/docs/installation/#building-from-source) for instructions on how to build mqtt-cli
74
71
- Before proceeding to the next step, please make sure that your changes build and all tests succeed
75
72
- Tip: After building mqtt-cli you can execute the cli by using the generated jar file `java -jar build/libs/mqtt-cli-<version>.jar` (you can also just build this jar by using `./gradlew shadowJar`)
76
73
- Tip: To quickly test your changes manually you can directly execute commands from your IDE by going to <i>Run > Edit Configurations...</i> and adding your cli arguments
@@ -80,6 +77,7 @@ Furthermore, the following is needed to make your development efforts as smoothl
80
77
81
78
## 6. Commit and Push
82
79
- Before committing execute `./gradlew licenseFormat` to add license headers to each file
80
+
-[Reformat each changed file](https://www.jetbrains.com/help/idea/reformat-and-rearrange-code.html#reformat_file) using the .editorconfig settings of the project
83
81
- Commit your changes directly from IntelliJ by pressing `Command` + `K` OR via the command `git commit -m "your commit mesage"`
84
82
- Commits should be as atomic as possible
85
83
- Commit messages should describe the changes clearly
[](https://github.com/hivemq/mqtt-cli/actions/workflows/check.yml?query=branch%3Amaster)
- If you want to request a feature or report a bug, please [create a GitHub Issue using one of the provided templates](https://github.com/hivemq/mqtt-cli/issues/new/choose)
68
70
- If you want to make a contribution to the project, please have a look at the [contribution guide](CONTRIBUTING.md)
0 commit comments