#22 parse downtime-replicas as int

Author: hjacobs

kube_downscaler/scaler.py

@@ -69,7 +69,7 @@ def autoscale_resource(resource: pykube.objects.NamespacedAPIObject,
                     logger.info('%s %s/%s within grace period (%ds), not scaling down (yet)',
                                 resource.kind, resource.namespace, resource.name, grace_period)
                 else:
-                    target_replicas = resource.annotations.get(DOWNTIME_REPLICAS_ANNOTATION, 0)
+                    target_replicas = int(resource.annotations.get(DOWNTIME_REPLICAS_ANNOTATION, 0))
                     logger.info('Scaling down %s %s/%s from %s to %s replicas (uptime: %s, downtime: %s)',
                                 resource.kind, resource.namespace, resource.name, replicas, target_replicas,
                                 uptime, downtime)

tests/test_autoscale_resource.py

@@ -4,7 +4,7 @@
 from datetime import datetime
 from unittest.mock import MagicMock
 
-from kube_downscaler.scaler import autoscale_resource, EXCLUDE_ANNOTATION, ORIGINAL_REPLICAS_ANNOTATION
+from kube_downscaler.scaler import autoscale_resource, EXCLUDE_ANNOTATION, ORIGINAL_REPLICAS_ANNOTATION, DOWNTIME_REPLICAS_ANNOTATION
 
 
 @pytest.fixture
@@ -107,3 +107,24 @@ def test_scale_up(resource):
     autoscale_resource(resource, 'Mon-Fri 07:30-20:30 Europe/Berlin', 'never', False, False, now, 0)
     assert resource.replicas == 3
     resource.update.assert_called_once()
+
+
+def test_downtime_replicas_invalid(resource):
+    resource.annotations = {DOWNTIME_REPLICAS_ANNOTATION: 'x'}
+    resource.replicas = 2
+    now = datetime.strptime('2018-10-23T21:56:00Z', '%Y-%m-%dT%H:%M:%SZ')
+    resource.metadata = {'creationTimestamp': '2018-10-23T21:55:00Z'}
+    autoscale_resource(resource, 'never', 'always', False, False, now, 0)
+    assert resource.replicas == 2
+    resource.update.assert_not_called()
+
+
+def test_downtime_replicas_valid(resource):
+    resource.annotations = {DOWNTIME_REPLICAS_ANNOTATION: '1'}
+    resource.replicas = 2
+    now = datetime.strptime('2018-10-23T21:56:00Z', '%Y-%m-%dT%H:%M:%SZ')
+    resource.metadata = {'creationTimestamp': '2018-10-23T21:55:00Z'}
+    autoscale_resource(resource, 'never', 'always', False, False, now, 0)
+    assert resource.replicas == 1
+    resource.update.assert_called_once()
+    assert resource.annotations[ORIGINAL_REPLICAS_ANNOTATION] == '2'