Skip to content
This repository was archived by the owner on Jul 31, 2019. It is now read-only.
This repository was archived by the owner on Jul 31, 2019. It is now read-only.

On windows, getting chrome version opens browser and does not work. #6

@cderv

Description

@cderv

I am on windows 10 and decapitated::chrome_version() is not working properly. This affects others functions that calls it, like decapitated::chrome_dump_pdf().

This is a related to a known bug I think
https://bugs.chromium.org/p/chromium/issues/detail?id=158372
--version does not work on windows.

Looking at the code, I am not sure to see why the need to get the version. In chrome_dump_pdf for example, vers is not used after being assigned. Should we get rid of chrome_version calls in functions that do not need it ?

If version is needed, it needs a workaround on windows.

To share, in case you don't know, there is another approach with chrome headless in pagedown to propose a function like chrome_dump_pdf

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions