Skip to content
This repository was archived by the owner on Feb 8, 2021. It is now read-only.

Commit 7da3a92

Browse files
authored
Merge pull request #413 from resouer/rand-service
Randomize service container name
2 parents 52648a4 + 40fb834 commit 7da3a92

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

daemon/list.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ package daemon
22

33
import (
44
"fmt"
5+
"strings"
56

67
"github.com/hyperhq/runv/hypervisor"
78
"github.com/hyperhq/runv/hypervisor/types"
@@ -104,10 +105,10 @@ func filterPodContainers(pod *hypervisor.PodStatus, aux bool) []*hypervisor.Cont
104105
results := make([]*hypervisor.ContainerStatus, 0)
105106

106107
filterServiceDiscovery := !aux && (pod.Type == "service-discovery")
107-
proxyName := "/" + ServiceDiscoveryContainerName(pod.Name)
108108

109109
for _, c := range pod.Containers {
110-
if filterServiceDiscovery && c.Name == proxyName {
110+
// NOTE(harry) filter out containers ended with "service-discovery" which is for internal usage
111+
if filterServiceDiscovery && strings.HasSuffix(c.Name, "service-discovery") {
111112
continue
112113
}
113114
results = append(results, c)

daemon/servicediscovery.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -166,5 +166,5 @@ func ParseServiceDiscovery(id string, spec *pod.UserPod) error {
166166
}
167167

168168
func ServiceDiscoveryContainerName(podName string) string {
169-
return podName + "-service-discovery"
169+
return podName + "-" + utils.RandStr(10, "alpha") + "-service-discovery"
170170
}

0 commit comments

Comments
 (0)