IBX-10458: Applied review remarks

Author: barw4

src/contracts/Persistence/Content/Type/CriterionHandlerInterface.php

@@ -18,12 +18,12 @@
 interface CriterionHandlerInterface
 {
     /**
-     * @param TCriterion $criterion
+     * @phpstan-param TCriterion $criterion
      */
     public function supports(CriterionInterface $criterion): bool;
 
     /**
-     * @param TCriterion $criterion
+     * @phpstan-param TCriterion $criterion
      *
      * @return string|\Doctrine\DBAL\Query\Expression\CompositeExpression
      */

src/lib/Persistence/Legacy/Content/Type/Gateway/CriterionVisitor/CriterionVisitor.php

@@ -11,21 +11,20 @@
 use Doctrine\DBAL\Query\QueryBuilder;
 use Ibexa\Contracts\Core\Repository\Exceptions\NotImplementedException;
 use Ibexa\Contracts\Core\Repository\Values\ContentType\Query\CriterionInterface;
-use function Ibexa\PolyfillPhp82\iterator_to_array;
 
 final class CriterionVisitor
 {
     /**
-     * @var array<int, \Ibexa\Contracts\Core\Persistence\Content\Type\CriterionHandlerInterface<\Ibexa\Contracts\Core\Repository\Values\ContentType\Query\CriterionInterface>>
+     * @var iterable<\Ibexa\Contracts\Core\Persistence\Content\Type\CriterionHandlerInterface<\Ibexa\Contracts\Core\Repository\Values\ContentType\Query\CriterionInterface>>
      */
-    private array $criterionHandlers;
+    private iterable $criterionHandlers;
 
     /**
      * @param iterable<\Ibexa\Contracts\Core\Persistence\Content\Type\CriterionHandlerInterface<\Ibexa\Contracts\Core\Repository\Values\ContentType\Query\CriterionInterface>> $criterionHandlers
      */
     public function __construct(iterable $criterionHandlers)
     {
-        $this->criterionHandlers = iterator_to_array($criterionHandlers);
+        $this->criterionHandlers = $criterionHandlers;
     }
 
     /**